feat: Make security baseline extension default-enabled (opt-out instead of opt-in)#240
Open
ai-ram-ramani wants to merge 2 commits into
Open
Conversation
Member
|
The contributor statement is missing. Extensions being on by default (opt-out) vs. optionally enabled (opt-in) is interesting. The RFC for extensions and PR to choose which extensions are enabled in one question should be reviewed: |
|
|
||
| ## Loading Behavior | ||
|
|
||
| Unlike standard opt-in extensions, this extension's full rules file (`security-baseline.md`) is loaded immediately at workflow start — before the user answers the opt-out question. This ensures security rules are enforced from the earliest stages. |
Contributor
There was a problem hiding this comment.
Why should it be loaded "immediately at workflow start"? Shouldn't the loading behavior still be the same, just that opt-in language becomes opt-out language?
Contributor
Author
There was a problem hiding this comment.
sorry i don't understand. We want it to be security by default, so always loaded during workspace detection but if opted out then security rules are not considered. It did work for me, but I don't think it undid the context add.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the security baseline extension from opt-in to default-enabled (opt-out). Security rules are now loaded and enforced from workflow start. Users can explicitly disable them during Requirements Analysis if needed (e.g., for throwaway PoCs).
Motivation
Security should be on by default — requiring users to opt in means most projects run without security rules unless someone actively remembers to enable them. This change flips the default so the path of least resistance is the secure path.
Changes
security-baseline.opt-in.md**Default**: Enabledmetadata flagcore-workflow.md(Extensions Loading section)*.opt-in.mdfor**Default**: Enabledrequirements-analysis.md(Step 5.1)Backward Compatibility
**Default**: Enabledin its opt-in file behaves exactly as before**Default**: Enabledflag is additive — only extensions that declare it get the new behaviorTesting
Validated end-to-end in Kiro IDE:
Test 1: Default behavior (keep enabled)
Test 2: Explicit opt-out (disable)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.