-
Notifications
You must be signed in to change notification settings - Fork 348
feat: Make security baseline extension default-enabled (opt-out instead of opt-in) #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ai-ram-ramani
wants to merge
2
commits into
awslabs:main
Choose a base branch
from
ai-ram-ramani:feat/security-baseline-default-enabled
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 13 additions & 6 deletions
19
...aws-aidlc-rule-details/extensions/security/baseline/security-baseline.opt-in.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,25 @@ | ||
| # Security Baseline — Opt-In | ||
| # Security Baseline — Default Enabled (Opt-Out) | ||
|
|
||
| **Extension**: Security Baseline | ||
| **Default**: Enabled — rules are enforced unless the user explicitly opts out. | ||
|
|
||
| ## Opt-In Prompt | ||
| ## Opt-Out Prompt | ||
|
|
||
| The following question is automatically included in the Requirements Analysis clarifying questions when this extension is loaded: | ||
|
|
||
| ```markdown | ||
| ## Question: Security Extensions | ||
| Should security extension rules be enforced for this project? | ||
| Security baseline rules (OWASP-based) are **enabled by default** for this project. No action is needed to keep them active. | ||
|
|
||
| A) Yes — enforce all SECURITY rules as blocking constraints (recommended for production-grade applications) | ||
| B) No — skip all SECURITY rules (suitable for PoCs, prototypes, and experimental projects) | ||
| X) Other (please describe after [Answer]: tag below) | ||
| If you want to disable security rules (e.g., for a throwaway PoC or experimental prototype), type "disable" below. Otherwise, leave blank or type "keep". | ||
|
|
||
| [Answer]: | ||
| ``` | ||
|
|
||
| ## Loading Behavior | ||
|
|
||
| Unlike standard opt-in extensions, this extension's full rules file (`security-baseline.md`) is loaded immediately at workflow start — before the user answers the opt-out question. This ensures security rules are enforced from the earliest stages. | ||
|
|
||
| If the user types "disable" during Requirements Analysis, the extension is marked as disabled in `aidlc-docs/aidlc-state.md` and enforcement stops from that point forward. | ||
|
|
||
| If the user leaves the answer blank, types "keep", or does not answer the question, enforcement continues unchanged. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should it be loaded "immediately at workflow start"? Shouldn't the loading behavior still be the same, just that opt-in language becomes opt-out language?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i don't understand. We want it to be security by default, so always loaded during workspace detection but if opted out then security rules are not considered. It did work for me, but I don't think it undid the context add.