test: improve configuration deserialization testing #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weibenz1
reviewed
Dec 2, 2025
|
|
||
| ## How It Works | ||
|
|
||
| The negative tests use **RustEmbed** to embed these invalid test files at compile time, just like the production code embeds valid configuration files. The key difference is: |
Contributor
There was a problem hiding this comment.
Are we actually compiling it and do we need to?
Contributor
Author
There was a problem hiding this comment.
I think RustEmbed actually does not embed them for debug builds, but it abstracts that away from us. I think the point is more that we use the same interface to consume these files. I can update the comment as part of fixing the build.
Contributor
|
PR check failed with error - https://github.com/awslabs/iam-policy-autopilot/actions/runs/19862429036/job/56915850649?pr=47#step:7:945 |
Contributor
Author
|
Yes, I noticed that this needs some more work and I opened this prematurely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Improve testing when configuration files have invalid data. Instead of continueing on wrong data at runtime, we now fail, as we know that we will have parsed the same files (the same way!) during testing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.