Extending jtc and adding ctg #15

destogl · 2023-12-11T17:44:49Z

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
Give your PR a descriptive title. Add a short summary, if required.
Make sure the pipeline is green.
Don’t be afraid to request reviews from maintainers.
New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

Fork the repository.
Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
Commit to your fork using clear commit messages.
Send a pull request, answering any default questions in the pull request interface.
Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

mergify · 2023-12-18T16:40:24Z

This pull request is in conflict. Could you fix it @destogl?

* Convert lambdas to member functions * Make member function const * Add a test for compute_error function * Make reference_wrapper argument const * Iterate over error fields

…'command_interfaces' parameters (ros-controls#967)" (ros-controls#978) This reverts commit 6e2736b.

…arameters on configure (ros-controls#698)" (ros-controls#988) This reverts commit 32aaef7.

Bumps [ros-tooling/action-ros-ci](https://github.com/ros-tooling/action-ros-ci) from 0.3.5 to 0.3.6. - [Release notes](https://github.com/ros-tooling/action-ros-ci/releases) - [Commits](ros-tooling/action-ros-ci@0.3.5...0.3.6) --- updated-dependencies: - dependency-name: ros-tooling/action-ros-ci dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.4...v3.1.5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.2.0...v4.3.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ntation (ros-controls#652)

…ls#899)

…reaking (ros-controls#958)

…os-controls#1021)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.5 to 4.0.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.5...v4.0.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dr. Denis <[email protected]>

…values deduction.

Added save_iterm parameter Added check for default false in tests Applied suggestions from code review More comment updates

mergify · 2024-02-19T10:39:01Z

This pull request is in conflict. Could you fix it @destogl?

github-actions · 2025-04-15T12:17:00Z

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

mergify · 2025-04-15T12:17:46Z

This pull request is in conflict. Could you fix it @destogl?

github-actions · 2025-06-02T12:17:56Z

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

destogl force-pushed the extending-jtc-and-adding-ctg branch from 8903b39 to 1305057 Compare December 18, 2023 17:56

christophfroehlich and others added 28 commits January 15, 2024 10:13

Update mergify.yml (ros-controls#974)

3809db7

[PID] Remove joint_jog include (ros-controls#975)

d5f1eab

Bump actions/upload-artifact from 4.0.0 to 4.1.0 (ros-controls#976)

2f7a755

[JTC] Convert lambda to class functions (ros-controls#945)

833ed7f

* Convert lambdas to member functions * Make member function const * Add a test for compute_error function * Make reference_wrapper argument const * Iterate over error fields

Bump actions/upload-artifact from 4.1.0 to 4.2.0 (ros-controls#984)

d696767

Update mergify.yml (ros-controls#982)

3ab3759

[CI] debian + RHEL updates (ros-controls#985)

0bcb77b

Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and …

9f7e9e9

…'command_interfaces' parameters (ros-controls#967)" (ros-controls#978) This reverts commit 6e2736b.

Revert "[ForceTorqueSensorBroadcaster] Create ParamListener and get p…

7fee940

…arameters on configure (ros-controls#698)" (ros-controls#988) This reverts commit 32aaef7.

[tricycle_controller] Use generate_parameter_library (ros-controls#957)

8d732f1

[JTC] Invalidate empty trajectory messages (ros-controls#902)

99fadce

Let sphinx add parameter description with nested structures to docume…

f375c69

…ntation (ros-controls#652)

Add tests for interface_configuration_type consistently (ros-contro…

f2f36c0

…ls#899)

[diff_drive] Remove unused parameter and add simple validation #abi-b…

2705ca8

…reaking (ros-controls#958)

[JTC] Fill action error_strings (ros-controls#887)

67dbf7b

Update changelogs

08ea6cf

4.5.0

fd8b91f

Fix tests for using new get_node_options API (ros-controls#840)

2817f27

Use correct ref for scheduled workflows (ros-controls#1013)

737a45b

Add test_depend on hardware_interface_testing (ros-controls#1018)

8bf379b

Add test_depend on hardware_interface_testing also for diff_drive (r…

c786604

…os-controls#1021)

[CI] Improvements and Cleanups (ros-controls#1028)

1266941

Make some methods virtual for extending of JTC. Extend caculation of …

e1647c7

…values deduction.

bijoua29 and others added 21 commits February 9, 2024 14:13

Handle NaNs in measured state in CTG

177a242

Update JTC to be more extensible.

e178549

Updated CTG to have custom state message.

2dfedc8

Fix stair step in JTC when new trajectory message received

9119f51

Reset initial value of last commanded time to 0.

e506ba6

Use previous state for limiters.

72874be

Use values, if present in reset dofs service, instead of fb to reset

3f10cd1

Fix bug when two reset dofs req sent without being processed in between

7b2b089

Update reset dofs output messages in JTC

e4054ad

Remove service for setting joint limits in CTG.

e5edfe5

Cleanup rucking code and add simple joint limiter.

d2717a3

Fixup JTC and Trajectory to compile.

e31691f

Fixup CTG to compile.

753d83b

Added support for save integral term parameter

2350810

Added save_iterm parameter Added check for default false in tests Applied suggestions from code review More comment updates

Fix JTC crashes

f7d7466

Fixup one crash of JTC.

b203869

Move resetting of the axis values from lambda to a method.

cc5fc7a

Adjust variable name to avoid shadowing.

1ed60eb

Bugfixing.

54b195f

Increasing code readability in JTC

34efa25

Adjusting CTG with limiters.

1ca51d1

destogl force-pushed the extending-jtc-and-adding-ctg branch 2 times, most recently from 7e93fb0 to 1ca51d1 Compare February 11, 2024 17:14

github-actions bot added the stale label Apr 15, 2025

github-actions bot removed the stale label Apr 16, 2025

github-actions bot added the stale label Jun 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extending jtc and adding ctg #15

Extending jtc and adding ctg #15

Uh oh!

destogl commented Dec 11, 2023

Uh oh!

mergify bot commented Dec 18, 2023

Uh oh!

mergify bot commented Feb 19, 2024

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

mergify bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Extending jtc and adding ctg #15

Are you sure you want to change the base?

Extending jtc and adding ctg #15

Uh oh!

Conversation

destogl commented Dec 11, 2023

Uh oh!

mergify bot commented Dec 18, 2023

Uh oh!

mergify bot commented Feb 19, 2024

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

mergify bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants