Skip to content

fix(packagexml): include example_interfaces for ros depenendency whil… #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 69 commits into
base: only-gpio-tool-controller
Choose a base branch
from
Open

fix(packagexml): include example_interfaces for ros depenendency whil… #28

wants to merge 69 commits into from

Conversation

ShreyasManjunath
Copy link

…e building

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

sachinkum0009 and others added 30 commits December 21, 2024 18:57
@sachinkum0009
io gripper controller added which provides functionality to control g…
3f6a373 
…ripper using ios
@sachinkum0009
Merge branch 'ros-controls:master' into io_gripper_controller
f5163ed
@sachinkum0009
cleaned the code to impove the readabiligy and consistency
353b42a
@sachinkum0009
using result from set_value
2a5fd5e 
- minor code clean
@destogl
Delete io_gripper_controller/include/io_gripper_controller/visibility…
913ab88 
…_control.h
@destogl
Delete io_gripper_controller/doc/.gitkeep
e079889
@sachinkum0009
- removed visibility macros and used solution S1 for visibility macros
4640609 
- removed the template from license
- added one variable per line
- documented the enums
- updated the doc folder as per `joint_trajectory_controller`
@sachinkum0009 @destogl
Update io_gripper_controller/CMakeLists.txt
0ebb499 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009 @destogl
Update io_gripper_controller/CMakeLists.txt
b13c507 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009 @destogl
removed interface package deps
8571d6f 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009 @destogl
removed license from xml
69c47ce 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009
deps changed alphabetically
f357e97
@sachinkum0009
author and maintainer list updated
8acbec5
@sachinkum0009
doc strings with descript of inputs and outputs updated
099337c
@sachinkum0009
pkg deps aranged alphabatically
d4facba
@sachinkum0009
deps updated as per cmakelist
f7b4875
@sachinkum0009 @destogl
OpenSrvType changed to OpenCloseSrvType
dc5e828 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009
opensrvtype changed to openclosesrvtype
94c9b81
@sachinkum0009 @destogl
controllerStateMsg changed to jointStateMsg
534a723 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009
controllerStateMsg changed to jointStateMsg for other files
0c08284
@sachinkum0009 @destogl
InterfaceMsg renamed to DynInterfaceMsg
cd0d6a5 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009
InterfaceMsg renamed to DynInterfaceMsg for all files
485abbf
@sachinkum0009
interface named changes as per control_msgs
d7394e4
@sachinkum0009 @destogl
removed unused code
2bd2bd2 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009
- doc string added for rt buffer members
ac2fc99 
- renamed service_buffer_ to gripper_service_buffer_
@sachinkum0009
removed unused code
545d28d
@sachinkum0009
pre-commit changes
3943aff
@sachinkum0009
user doc reformatted
37874af
@sachinkum0009 @destogl
user doc updated
a20a981 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009 @destogl
Update io_gripper_controller/doc/userdoc.rst
9c62539 
Co-authored-by: Dr. Denis <[email protected]>
destogl and others added 22 commits January 20, 2025 16:53
@destogl
Apply suggestions from code review
ede058d
@sachinkum0009
accepting upcoming changes
6bf304c
@sachinkum0009
compilation issue fixed
2c5e682
@sachinkum0009
changes to use the message IOGripperState intsead of enum
dfcd97d
@sachinkum0009
Set ros2_control_test_assets as test_depend
7056b9a
@sachinkum0009 @destogl
email updated
268561e 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009 @destogl
Update io_gripper_controller/include/io_gripper_controller/io_gripper…
0ed5689 
…_controller.hpp


minor changes

Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009 @destogl
Apply suggestions from code review
7950394 
Co-authored-by: Dr. Denis <[email protected]>
@sachinkum0009
udpate handle_gripper_transisition
40a12ac 
- parse method for adding multiple states
- update to store configuraiton in new struct for closed_ios_
@sachinkum0009
fix logic for open gripper
860c2d3
@sachinkum0009
close state and open state code updated
4633fd6
@sachinkum0009
minor changes for timeout function
58a335b
@sachinkum0009
timeout feature updated
5bd4221 
updated the param for yaml
@sachinkum0009
test yaml file added
06678d1
@sachinkum0009
fixing header files
698ba7b
@sachinkum0009
fixing header files
a91bfc3
@sachinkum0009
header files changed for unit tests
5f48cd8
@sachinkum0009
header files changed for unit tests
6d555a9
@sachinkum0009
header files changed for unit tests
ac961cb
@destogl
Rewrote IO Gripper Controller to GPIO Tool Controller.
4ffbec4
@destogl
Ignore all other packages.
c352291
fix(packagexml): include example_interfaces for ros depenendency whil…
5da39ca 
…e building
@mergify Mergify
Copy link

mergify bot commented Jun 17, 2025

@ShreyasManjunath, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to only-gpio-tool-controller, but it must be in master
to have these changes reflected into new distributions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Aug 4, 2025
@destogl destogl force-pushed the only-gpio-tool-controller branch from 57fdbcb to a3c9553 Compare August 16, 2025 19:24
@github-actions github-actions bot removed the stale label Aug 18, 2025
@mergify Mergify
Copy link

mergify bot commented Aug 18, 2025

This pull request is in conflict. Could you fix it @ShreyasManjunath?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShreyasManjunath @sachinkum0009 @destogl