Use strict guards before BigNumber conversions - #2594
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…alidation Replace isValidNumber with isBnParseable in isGreaterThanZeroValidation to prevent throwing errors on whitespace input. Add test coverage for whitespace handling and other edge cases.
Replace !isZero(value) with bn(value).gt(0) to properly validate that amounts are strictly greater than zero, not just non-zero (which would allow negative values).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isBnParseableat API and input boundaries that feedbn()Tests
pool.utils.spec.tsuser-balance.helpers.spec.tsuseGetPoolRewards.spec.tsxScoped to
packages/lib