Use strict guards before BigNumber conversions

packages/lib/modules/lbp/pool/usePriceInfo.ts

@@ -12,7 +12,7 @@ import {
   secondsToMilliseconds,
   startOfHour,
 } from 'date-fns'
-import { bn, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { Address } from 'viem'
 import { now } from '@repo/lib/shared/utils/time'
 
@@ -61,7 +61,7 @@ export function usePriceInfo(chain: GqlChain, poolId: Address, isFixedLbp = fals
 function toLbpSnapshots(apiPrices: LbpPriceChartDataFragment[]): LbpSnapshot[] {
   return apiPrices.map(price => ({
     timestamp: new Date(secondsToMilliseconds(price.timestamp)),
-    projectTokenPrice: isValidNumber(price.projectTokenPrice)
+    projectTokenPrice: isBnParseable(price.projectTokenPrice)
       ? bn(price.projectTokenPrice)
           .times(price.reservePrice || 1)
           .toNumber()

packages/lib/modules/pool/LbpDetail/LbpPoolCharts/LbpPoolChartsProvider.tsx

@@ -16,7 +16,7 @@ import {
 } from 'date-fns'
 import { LbpV3 } from '@repo/lib/modules/pool/pool.types'
 import { isFixedLBP } from '@repo/lib/modules/pool/pool.helpers'
-import { bn, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { isSameAddress } from '@repo/lib/shared/utils/addresses'
 
 type LbpPoolChartsContextType = ReturnType<typeof useLbpPoolChartsLogic>
@@ -62,7 +62,7 @@ export function useLbpPoolChartsLogic() {
     .toNumber()
 
   const fundsRaisedGoal =
-    projectToken?.balance && isValidNumber(projectToken.balance) && projectTokenRate
+    projectToken?.balance && isBnParseable(projectToken.balance) && projectTokenRate
       ? bn(projectToken.balance).times(projectTokenRate).toNumber()
       : null
 

packages/lib/modules/pool/PoolDetail/PoolComposition.tsx

@@ -18,7 +18,7 @@ import { useTokens } from '@repo/lib/modules/tokens/TokensProvider'
 import { useBreakpoints } from '@repo/lib/shared/hooks/useBreakpoints'
 import { useCurrency } from '@repo/lib/shared/hooks/useCurrency'
 import type { GqlChain } from '@repo/lib/shared/services/api/generated/graphql'
-import { bn, fNum, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, fNum, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { useLayoutEffect, useRef, useState, Fragment } from 'react'
 import { Address } from 'viem'
 import { usePoolsMetadata } from '../metadata/PoolsMetadataProvider'
@@ -51,7 +51,7 @@ function CardContent({ totalLiquidity, poolTokens, chain, pool }: CardContentPro
     const virtualToken = pool.poolTokens[pool.reserveTokenIndex].address
     const price = priceFor(virtualToken, chain)
     virtualAmount =
-      isValidNumber(pool.reserveTokenVirtualBalance) && isValidNumber(price)
+      isBnParseable(pool.reserveTokenVirtualBalance) && isBnParseable(price)
         ? bn(pool.reserveTokenVirtualBalance).times(price).toString()
         : '0'
   }
@@ -86,7 +86,7 @@ function CardContent({ totalLiquidity, poolTokens, chain, pool }: CardContentPro
 
           const tokenValue =
             isSeedlessLBP && isVirtualPairedToken
-              ? isValidNumber(poolToken.balance) && isValidNumber(pool.reserveTokenVirtualBalance)
+              ? isBnParseable(poolToken.balance) && isBnParseable(pool.reserveTokenVirtualBalance)
                 ? bn(poolToken.balance).plus(pool.reserveTokenVirtualBalance)
                 : poolToken.balance
               : poolToken.balance
@@ -109,8 +109,8 @@ function CardContent({ totalLiquidity, poolTokens, chain, pool }: CardContentPro
                 <VStack pl="8" w="full">
                   {getNestedPoolTokens(poolToken).map(nestedPoolToken => {
                     const calculatedWeight =
-                      isValidNumber(nestedPoolToken.balanceUSD) &&
-                      isValidNumber(poolToken.balanceUSD)
+                      isBnParseable(nestedPoolToken.balanceUSD) &&
+                      isBnParseable(poolToken.balanceUSD)
                         ? bn(nestedPoolToken.balanceUSD).div(bn(poolToken.balanceUSD))
                         : bn(0)
                     return (
@@ -124,8 +124,8 @@ function CardContent({ totalLiquidity, poolTokens, chain, pool }: CardContentPro
                         targetWeight={
                           nestedPoolToken.weight &&
                           poolToken.weight &&
-                          isValidNumber(nestedPoolToken.weight) &&
-                          isValidNumber(poolToken.weight)
+                          isBnParseable(nestedPoolToken.weight) &&
+                          isBnParseable(poolToken.weight)
                             ? bn(nestedPoolToken.weight).times(poolToken.weight).toString()
                             : undefined
                         }
@@ -140,8 +140,8 @@ function CardContent({ totalLiquidity, poolTokens, chain, pool }: CardContentPro
                 <VStack pl="8" w="full">
                   <TokenRow
                     actualWeight={
-                      isValidNumber(poolToken.balance) &&
-                      isValidNumber(pool.reserveTokenVirtualBalance)
+                      isBnParseable(poolToken.balance) &&
+                      isBnParseable(pool.reserveTokenVirtualBalance)
                         ? bn(actualWeight)
                             .times(pool.reserveTokenVirtualBalance)
                             .div(bn(poolToken.balance).plus(pool.reserveTokenVirtualBalance))
@@ -159,8 +159,8 @@ function CardContent({ totalLiquidity, poolTokens, chain, pool }: CardContentPro
                   />
                   <TokenRow
                     actualWeight={
-                      isValidNumber(poolToken.balance) &&
-                      isValidNumber(pool.reserveTokenVirtualBalance)
+                      isBnParseable(poolToken.balance) &&
+                      isBnParseable(pool.reserveTokenVirtualBalance)
                         ? bn(actualWeight)
                             .times(poolToken.balance)
                             .div(bn(poolToken.balance).plus(pool.reserveTokenVirtualBalance))

packages/lib/modules/pool/actions/add-liquidity/useIsMinimumDepositMet.ts

@@ -4,7 +4,7 @@ import { HumanAmount, isSameAddress } from '@balancer/sdk'
 import { HumanTokenAmountWithSymbol } from '@repo/lib/modules/tokens/token.types'
 import { useTokens } from '@repo/lib/modules/tokens/TokensProvider'
 import { useGetMinimumWrapAmount } from '@repo/lib/shared/hooks/useGetMinimumWrapAmount'
-import { bn, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { Address, formatUnits, zeroAddress } from 'viem'
 import { getCompositionTokens } from '../../pool-tokens.utils'
 import { usePool } from '../../PoolProvider'
@@ -23,7 +23,7 @@ export function useIsMinimumDepositMet({ humanAmountsIn, totalUSDValue }: Props)
   const { minimumWrapAmount } = useGetMinimumWrapAmount(chain)
   const { minimumTradeAmount } = useGetMinimumTradeAmount(chain)
 
-  if (!isValidNumber(totalUSDValue) || bn(totalUSDValue).isZero()) {
+  if (!isBnParseable(totalUSDValue) || bn(totalUSDValue).isZero()) {
     return { isMinimumDepositMet: true, errors: {} }
   }
 
@@ -101,7 +101,7 @@ export function useIsMinimumDepositMet({ humanAmountsIn, totalUSDValue }: Props)
     ) {
       address = token.underlyingToken.address
       balance =
-        isValidNumber(token.balance) && isValidNumber(token.priceRate)
+        isBnParseable(token.balance) && isBnParseable(token.priceRate)
           ? bn(token.balance).div(token.priceRate).toString()
           : '0'
       decimals = token.underlyingToken.decimals

packages/lib/modules/pool/actions/stake.helpers.ts

@@ -1,4 +1,4 @@
-import { bn, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { Pool } from '../pool.types'
 import { Address } from 'viem'
 import { HumanAmount } from '@balancer/sdk'
@@ -110,7 +110,7 @@ function filterNonPreferentialStakingWithBalance(pool: Pool): GqlUserStakedBalan
     stakedBalance =>
       stakedBalance.stakingType === GqlPoolStakingTypeValues.Gauge &&
       stakedBalance.stakingId !== pool.staking?.gauge?.id &&
-      isValidNumber(stakedBalance.balance) &&
+      isBnParseable(stakedBalance.balance) &&
       bn(stakedBalance.balance).gt(0)
   )
   return found

packages/lib/modules/pool/pool.utils.spec.ts

@@ -0,0 +1,17 @@
+import type { GqlPoolAprItem } from '@repo/lib/shared/services/api/graphql-derived-types'
+import { GqlPoolAprItemTypeValues } from '@repo/lib/shared/services/api/graphql-enums'
+import { describe, expect, test } from 'vitest'
+import { getTotalApr } from './pool.utils'
+
+describe('getTotalApr', () => {
+  test('skips API APR values that BigNumber cannot parse', () => {
+    const aprItems = [
+      { type: GqlPoolAprItemTypeValues.SwapFee24h, apr: ' ' } as unknown as GqlPoolAprItem,
+    ]
+
+    const [minTotal, maxTotal] = getTotalApr(aprItems)
+
+    expect(minTotal.toString()).toBe('0')
+    expect(maxTotal.toString()).toBe('0')
+  })
+})

packages/lib/modules/pool/pool.utils.ts

@@ -9,7 +9,7 @@ import {
   GqlPoolAprItemTypeValues,
   GqlPoolTypeValues,
 } from '@repo/lib/shared/services/api/graphql-enums'
-import { Numberish, bn, fNum, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { Numberish, bn, fNum, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import type BigNumber from 'bignumber.js'
 import { cloneDeep, invert } from 'lodash'
 import { AppRouterInstance } from 'next/dist/shared/lib/app-router-context.shared-runtime'
@@ -138,7 +138,7 @@ export function getTotalApr(aprItems: GqlPoolAprItem[]): [BigNumber, BigNumber]
     // Filter known APR types to avoid including new unknown API types that are not yet displayed in the APR tooltip
     .filter(item => TOTAL_APR_TYPES.includes(item.type))
     .forEach(item => {
-      if (!isValidNumber(item.apr)) return
+      if (!isBnParseable(item.apr)) return
 
       if (item.type === GqlPoolAprItemTypeValues.StakingBoost) {
         maxTotal = bn(item.apr).plus(maxTotal)

packages/lib/modules/pool/queries/useOnchainUserPoolBalances.ts

@@ -4,7 +4,7 @@ import type {
 } from '@repo/lib/shared/services/api/graphql-derived-types'
 import type { GqlChain } from '@repo/lib/shared/services/api/generated/graphql'
 import { isSameAddress } from '@repo/lib/shared/utils/addresses'
-import { bn, safeSum, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, safeSum, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { captureNonFatalError } from '@repo/lib/shared/utils/query-errors'
 import { HumanAmount } from '@balancer/sdk'
 import type BigNumber from 'bignumber.js'
@@ -129,7 +129,7 @@ function overwriteOnchainPoolBalanceData(
     }
 
     const onchainUnstakedBalance = onchainUnstakedBalances.unstakedBalance as HumanAmount
-    const safeOnchainUnstakedBalance = isValidNumber(onchainUnstakedBalance)
+    const safeOnchainUnstakedBalance = isBnParseable(onchainUnstakedBalance)
       ? onchainUnstakedBalance
       : ('0' as HumanAmount)
     const onchainUnstakedBalanceUsd = bn(safeOnchainUnstakedBalance).times(bptPrice).toNumber()
@@ -142,7 +142,7 @@ function overwriteOnchainPoolBalanceData(
     }
     const onchainTotalStakedBalance = safeSum(
       onchainStakedBalances.map(stakedBalance =>
-        isValidNumber(stakedBalance.balance) ? stakedBalance.balance : '0'
+        isBnParseable(stakedBalance.balance) ? stakedBalance.balance : '0'
       )
     )
 

packages/lib/modules/pool/useGetPoolRewards.spec.tsx

@@ -53,7 +53,7 @@ function getPoolWithInvalidStakingGaugeRewards() {
   pool.staking.gauge.rewards = [
     {
       id: '0x5bbaed1fadc08c5fb3e4ae3c8848777e2da77103-0xba100000625a3754423978a60c9317c58a424e3d-balgauge',
-      rewardPerSecond: null as any,
+      rewardPerSecond: ' ' as any,
       tokenAddress: '0xba100000625a3754423978a60c9317c58a424e3d',
     } as GqlPoolStakingGaugeReward,
     {

packages/lib/modules/pool/useGetPoolRewards.tsx

@@ -2,7 +2,7 @@ import { Pool } from './pool.types'
 import type { GqlToken } from '@repo/lib/shared/services/api/graphql-derived-types'
 import { sumBy } from 'lodash'
 import { useTokens } from '../tokens/TokensProvider'
-import { bn, Numberish, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, Numberish, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { calcPotentialYieldFor } from './pool.utils'
 import { oneWeekInSecs } from '@repo/lib/shared/utils/time'
 
@@ -14,7 +14,7 @@ export function useGetPoolRewards(pool: Pool) {
   const currentRewardsPerWeek = currentRewards.map(reward => {
     return {
       ...reward,
-      rewardPerWeek: isValidNumber(reward.rewardPerSecond)
+      rewardPerWeek: isBnParseable(reward.rewardPerSecond)
         ? bn(reward.rewardPerSecond).times(oneWeekInSecs)
         : bn(0),
     }
@@ -33,7 +33,7 @@ export function useGetPoolRewards(pool: Pool) {
   const weeklyRewardsByToken = Object.fromEntries(
     currentRewards.map(reward => [
       reward.tokenAddress,
-      isValidNumber(reward.rewardPerSecond)
+      isBnParseable(reward.rewardPerSecond)
         ? bn(reward.rewardPerSecond).times(oneWeekInSecs).toString()
         : '0',
     ])

packages/lib/modules/pool/user-balance.helpers.spec.ts

@@ -119,7 +119,7 @@ describe('invalid balance fallbacks', () => {
       totalBalanceUsd: 300,
       stakedBalances: [
         {
-          balance: '',
+          balance: ' ',
           balanceUsd: 0,
           stakingType: GqlPoolStakingTypeValues.Gauge,
           stakingId: '0x1',

packages/lib/modules/pool/user-balance.helpers.ts

@@ -1,4 +1,4 @@
-import { bn, safeSum, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, safeSum, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { Pool } from './pool.types'
 import { PoolListItem } from './pool.types'
 import { parseUnits } from 'viem'
@@ -21,7 +21,7 @@ export function calcStakedBalance(
 
   return safeSum(
     filteredBalances.map(stakedBalance =>
-      isValidNumber(stakedBalance.balance) ? bn(stakedBalance.balance) : bn(0)
+      isBnParseable(stakedBalance.balance) ? bn(stakedBalance.balance) : bn(0)
     )
   ) as HumanAmount
 }
@@ -41,7 +41,7 @@ export function calcTotalStakedBalanceUsd(pool: Pool): number {
   return Number(
     safeSum(
       userBalance.stakedBalances.map(stakedBalance =>
-        isValidNumber(stakedBalance.balanceUsd) ? bn(stakedBalance.balanceUsd) : bn(0)
+        isBnParseable(stakedBalance.balanceUsd) ? bn(stakedBalance.balanceUsd) : bn(0)
       )
     )
   )
@@ -55,7 +55,7 @@ export function getUserTotalBalance(pool: Pool | PoolListItem): HumanAmount {
   const userBalance = pool.userBalance
   if (!userBalance) return '0'
 
-  return isValidNumber(userBalance.totalBalance)
+  return isBnParseable(userBalance.totalBalance)
     ? (bn(userBalance.totalBalance).toFixed(18) as HumanAmount)
     : '0'
 }
@@ -91,7 +91,7 @@ export function getUserTotalBalanceInt(pool: Pool): bigint {
   // decimals and so it borked the whole pool page. toFixed(18) ensures the
   // value cannot be more than 18 decimals when passed into parseUnits.
   const totalBalanceStr = getUserTotalBalance(pool)
-  const totalBalance = isValidNumber(totalBalanceStr)
+  const totalBalance = isBnParseable(totalBalanceStr)
     ? bn(totalBalanceStr).toFixed(BPT_DECIMALS)
     : '0'
   return parseUnits(totalBalance, BPT_DECIMALS)
@@ -150,7 +150,7 @@ export function calcStakedBalanceInt(pool: Pool, stakingType: GqlPoolStakingType
 
 export function calcStakedBalanceUsd(pool: Pool, stakingType: GqlPoolStakingType): number {
   const balanceUsd = getStakedBalance(pool, stakingType).balanceUsd
-  return isValidNumber(balanceUsd) ? Number(bn(balanceUsd)) : 0
+  return isBnParseable(balanceUsd) ? Number(bn(balanceUsd)) : 0
 }
 
 export function calcGaugeStakedBalanceUsd(pool: Pool): number {
@@ -159,7 +159,7 @@ export function calcGaugeStakedBalanceUsd(pool: Pool): number {
 
 export function hasTotalBalance(pool: Pool) {
   const totalBalance = getUserTotalBalance(pool)
-  return isValidNumber(totalBalance) && bn(totalBalance).gt(0)
+  return isBnParseable(totalBalance) && bn(totalBalance).gt(0)
 }
 
 export function hasBalancerStakedBalance(pool: Pool | PoolListItem): boolean {
@@ -180,7 +180,7 @@ export function hasStakedBalanceFor(
   return userBalance.stakedBalances.some(
     balance =>
       balance.stakingType === stakingType &&
-      isValidNumber(balance.balance) &&
+      isBnParseable(balance.balance) &&
       bn(balance.balance).gt(0)
   )
 }

packages/lib/modules/portfolio/PortfolioClaim/recovered-funds/useRecoveredFunds.ts

@@ -3,7 +3,7 @@ import { useQuery } from '@tanstack/react-query'
 import { MerklReward, MerklRewardsResponse } from '../../merkl/merkl.types'
 import { HumanTokenAmountWithSymbol } from '@repo/lib/modules/tokens/token.types'
 import { Address } from 'viem'
-import { bn, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { HumanAmount } from '@balancer/sdk'
 import { useState } from 'react'
 import { NORMALIZED_WRAPPER_TOKENS } from './wrapper-tokens'
@@ -73,7 +73,7 @@ export function useRecoveredFunds() {
 function toRecoveredTokenClaim(item: MerklReward): RecoveredTokenClaim {
   return {
     amount: {
-      humanAmount: isValidNumber(item.amount)
+      humanAmount: isBnParseable(item.amount)
         ? (bn(item.amount).shiftedBy(-item.token.decimals).toString() as HumanAmount)
         : ('0' as HumanAmount),
       tokenAddress: item.token.address as Address,

packages/lib/modules/portfolio/PortfolioClaim/useGetHiddenHandRewards.tsx

@@ -1,6 +1,6 @@
 import { useQuery } from '@tanstack/react-query'
 import { useUserAccount } from '../../web3/UserAccountProvider'
-import { bn, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { PROJECT_CONFIG } from '@repo/lib/config/getProjectConfig'
 import { useTokens } from '@repo/lib/modules/tokens/TokensProvider'
 
@@ -79,13 +79,13 @@ export function useGetHiddenHandRewards() {
     refetchInterval: 300000,
     select: data => {
       const filteredRewards = data.data.filter(
-        reward => isValidNumber(reward.claimable) && bn(reward.claimable).gt(0)
+        reward => isBnParseable(reward.claimable) && bn(reward.claimable).gt(0)
       )
 
       const aggregatedRewards = filteredRewards.reduce(
         (acc, reward) => {
           const tokenAddress = reward.token
-          if (!isValidNumber(reward.claimable)) return acc
+          if (!isBnParseable(reward.claimable)) return acc
 
           const rewardTokenUsdValue = usdValueForTokenAddress(
             tokenAddress,

packages/lib/modules/swap/handlers/AuraBalSwap.handler.ts

@@ -12,7 +12,7 @@ import {
 } from '../swap.types'
 import { getRpcUrl } from '../../web3/transports'
 import { isNativeAsset, isSameAddress } from '@repo/lib/shared/utils/addresses'
-import { bn, isValidNumber } from '@repo/lib/shared/utils/numbers'
+import { bn, isBnParseable } from '@repo/lib/shared/utils/numbers'
 import { ApiToken } from '../../tokens/token.types'
 
 export class AuraBalSwapHandler implements SwapHandler {
@@ -72,8 +72,8 @@ export class AuraBalSwapHandler implements SwapHandler {
       queryOutput.expectedAmountOut.token.decimals
     )
 
-    const safeSwapAmount = isValidNumber(variables.swapAmount) ? variables.swapAmount : '0'
-    const safeReturnAmount = isValidNumber(returnAmount) ? returnAmount : '0'
+    const safeSwapAmount = isBnParseable(variables.swapAmount) ? variables.swapAmount : '0'
+    const safeReturnAmount = isBnParseable(returnAmount) ? returnAmount : '0'
 
     return {
       returnAmount,