Skip to content

Conversation

@keith
Copy link
Member

@keith keith commented Jan 7, 2026

This warning seems to appear on almost every project I test things on,
implying that it's not very useful at driving any action, at the same
time it's noise that makes non-bazel-experts wonder if they're doing
something wrong, especially when they're adding a new test target.

Alternatively we could add yet another flag to disable this, but it
seems like it is fine to allow this flag to be one that is discovered
and passed manually when there is an issue.

This warning seems to appear on almost every project I test things on,
implying that it's not very useful at driving any action, at the same
time it's noise that makes non-bazel-experts wonder if they're doing
something wrong, especially when they're adding a new test target.

Alternatively we could add yet another flag to disable this, but it
seems like it is fine to allow this flag to be one that is discovered
and passed manually when there is an issue.
@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Jan 7, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the noisy warning that recommends using --test_verbose_timeout_warnings. The changes correctly remove the logic for displaying this warning by deleting the wasUnreportedWrongSize flag and its related handling across several files, including TerminalTestResultNotifier, TestResultAggregator, and TestSummary. The implementation preserves the existing behavior for verbose warnings when the flag is explicitly used. The related documentation and tests have also been updated accordingly. The changes are clean and effectively address the issue of excessive noise in test outputs.

@gregestren
Copy link
Contributor

That's some old code: 2010.. cl/15839396, cl/13194819, and b/2623366 have some history (Google-only). That includes removing the warning then re-enabling it. We should check if the rationale then makes any sense now

@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants