Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/start/go.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,6 @@ INFO: Build completed successfully, 1 total action
//fortune:fortune_test PASSED in 0.3s

Executed 0 out of 1 test: 1 test passes.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
```

You can use the `...` wildcard to run all tests. Bazel will also build targets
Expand Down
1 change: 0 additions & 1 deletion site/en/start/go.md
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,6 @@ INFO: Build completed successfully, 1 total action
//fortune:fortune_test PASSED in 0.3s

Executed 0 out of 1 test: 1 test passes.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
```

You can use the `...` wildcard to run all tests. Bazel will also build targets
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ private static class TestResultStats {
int failedLocallyCount;
int noStatusCount;
int numberOfExecutedTargets;
boolean wasUnreportedWrongSize;

int totalTestCases;
int totalFailedTestCases;
Expand Down Expand Up @@ -189,10 +188,6 @@ public void notify(Set<TestSummary> summaries, int numberOfExecutedTargets) {
stats.failedLocallyCount++;
}

if (summary.wasUnreportedWrongSize()) {
stats.wasUnreportedWrongSize = true;
}

stats.totalTestCases += summary.getTotalTestCases();
stats.totalUnknownTestCases += summary.getUnkownTestCases();
stats.totalFailedTestCases += summary.getFailedTestCases().size();
Expand Down Expand Up @@ -323,11 +318,5 @@ private void printStats(TestResultStats stats) {
stats.noStatusCount,
AnsiTerminalPrinter.Mode.DEFAULT));
}

if (stats.wasUnreportedWrongSize) {
printer.print("There were tests whose specified size is too big. Use the "
+ "--test_verbose_timeout_warnings command line option to see which "
+ "ones these are.\n");
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,12 @@ private void incrementalAnalyze(TestResult result) {
.setRanRemotely(result.getData().getIsRemoteStrategy());

List<String> warnings = new ArrayList<>();
if (status == BlazeTestStatus.PASSED
&& shouldEmitTestSizeWarningInSummary(
policy.testVerboseTimeoutWarnings,
warnings,
result.getData().getTestProcessTimesList(),
target)) {
summary.setWasUnreportedWrongSize(true);
if (status == BlazeTestStatus.PASSED) {
shouldEmitTestSizeWarningInSummary(
policy.testVerboseTimeoutWarnings,
warnings,
result.getData().getTestProcessTimesList(),
target);
}

summary
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ void mergeFrom(TestSummary existingSummary) {
setActionRan(existingSummary.actionRan);
setNumCached(existingSummary.numCached);
setRanRemotely(existingSummary.ranRemotely);
setWasUnreportedWrongSize(existingSummary.wasUnreportedWrongSize);
mergeSystemFailure(existingSummary.getSystemFailure());
}

Expand Down Expand Up @@ -318,13 +317,6 @@ public Builder setRanRemotely(boolean ranRemotely) {
return this;
}

@CanIgnoreReturnValue
public Builder setWasUnreportedWrongSize(boolean wasUnreportedWrongSize) {
checkMutation();
summary.wasUnreportedWrongSize = wasUnreportedWrongSize;
return this;
}

@CanIgnoreReturnValue
public Builder mergeSystemFailure(@Nullable DetailedExitCode systemFailure) {
checkMutation();
Expand Down Expand Up @@ -403,7 +395,6 @@ private void makeSummaryImmutable() {
private int numLocalActionCached;
private boolean actionRan;
private boolean ranRemotely;
private boolean wasUnreportedWrongSize;
private List<TestCase> failedTestCases = new ArrayList<>();
private final List<TestCase> passedTestCases = new ArrayList<>();
private final List<TestCase> skippedTestCases = new ArrayList<>();
Expand Down Expand Up @@ -502,10 +493,6 @@ public boolean ranRemotely() {
return ranRemotely;
}

public boolean wasUnreportedWrongSize() {
return wasUnreportedWrongSize;
}

public int getTotalTestCases() {
return totalTestCases;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ private TestSummary.Builder getTemplateBuilder() {
.setStatus(BlazeTestStatus.PASSED)
.setNumCached(NOT_CACHED)
.setActionRan(true)
.setRanRemotely(false)
.setWasUnreportedWrongSize(false);
.setRanRemotely(false);
}

private List<Path> getPathList(String... names) {
Expand Down Expand Up @@ -705,7 +704,6 @@ private static TestSummary createTestSummary(ConfiguredTarget target, BlazeTestS
.setNumCached(numCached)
.setActionRan(true)
.setRanRemotely(false)
.setWasUnreportedWrongSize(false)
.addFailedTestCases(emptyList, FailedTestCasesStatus.FULL)
.addTestTimes(SMALL_TIMING)
.build();
Expand Down