-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official support for Django 5.0 and Python 3.12, drop support for Django <3.2 #183
Add official support for Django 5.0 and Python 3.12, drop support for Django <3.2 #183
Conversation
As far as I can tell, the failures are from mypy, looks like the config crashes:
It fails on older versions too, so maybe it's a 3rd party package not being pinned properly? |
error: "type[UFMChild]" has no attribute "objects" [attr-defined] It's a Django model, this attribute exists...
Gentle ping @ir4y - what do we need to get this merged? |
Thank you for your contribution. Could you please fix the tests? Cheers, |
@browniebroke please feel free to include changes from #184 in this pull request and drop support for Django version that reached end of support period. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 3 3
Lines 227 227
=======================================
Hits 223 223
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ir4y it's all passing now. Since I opened this, Django 3.2 reached EOL and DRF 3.15 was released. I could go a few steps further and drop support for Django <4.2 (which would mean dropping DRF <3.14) and add support for DRF 3.15, but that feels like a lot? Do you want to merge this one and do a release before moving on to the next set of fixes? I'm trying to think of an upgrade path where users wouldn't have to upgrade too much at once, but actually I didn't really change anything in the code being released... Edit: further changes that build on top of this #186 can be merged after if you want |
No description provided.