-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy checks #184
Fix mypy checks #184
Conversation
efb801c
to
9a1c60f
Compare
506f4bc
to
a88cecf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 3 3
Lines 227 227
=======================================
Hits 223 223
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
error: "type[UFMChild]" has no attribute "objects" [attr-defined] It's a Django model, this attribute exists...
Looks like the failures are for older version of Django (3.1):
The latest versions of django-stubs and djangorestframework-stubs are for a specific version of Django and DRF, so I feel like we shouldn't type check for older versions... Thoughts? |
Alternatively, drop support for Django <3.2, which has been long unsupported: |
Tests are now passing, but it fails to upload to codecov... It seems unrelated to my change, but if someone can help resolving this, that would be appreciated. Thanks |
I think that the mypy tests are broken (See #183), so fixing them here before.