Android apk #1136 #1377
Merged
Android apk #1136 #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added packaging_format to GradleMixin.distribution_path
freakboy3742
requested changes
Jul 23, 2023
|
|
||
| # Make sure the dist folder exists | ||
| (tmp_path / "base_path" / "dist").mkdir(parents=True) | ||
| return command |
There was a problem hiding this comment.
This looks like it should be identical to the one in contest - can it be removed?
Comment on lines
37
to
38
| def test_default_packaging_format(package_command): | ||
| assert package_command.default_packaging_format == "aab" |
There was a problem hiding this comment.
This test case looks like it should be in the base test_package; although it's returning aab, that's because it's a default, not because aab has been selected here.
…ing docs consistent on other platforms)
freakboy3742
approved these changes
Jul 23, 2023
This was referenced Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added apk option to briefcase package android -p
briefcase package android shoul have a -p apk option, which will (a) compile a release APK, and (b) copy that release APK to the dist folder.
Fixes #1136
PR Checklist: