Skip to content

DREAMWORKSH743 external I2C bus#1025

Merged
haslinghuis merged 1 commit intomasterfrom
ot0tot-patch-3
Feb 6, 2026
Merged

DREAMWORKSH743 external I2C bus#1025
haslinghuis merged 1 commit intomasterfrom
ot0tot-patch-3

Conversation

@ot0tot
Copy link
Contributor

@ot0tot ot0tot commented Feb 6, 2026

External I2C is also on bus 1

Summary by CodeRabbit

  • Bug Fixes
    • Updated magnetometer sensor communication interface configuration for improved hardware compatibility and performance on supported devices.

External I2C is also on bus 1
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Walkthrough

Changes the magnetometer I2C bus configuration from I2CDEV_2 to I2CDEV_1 in the DREAMWORKSH743 board config file, aligning it with the barometer's I2C instance setting.

Changes

Cohort / File(s) Summary
Board Configuration
configs/DREAMWORKSH743/config.h
Updated MAG_I2C_INSTANCE macro from I2CDEV_2 to I2CDEV_1 to match barometer I2C assignment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Bugfix

Suggested reviewers

  • nerdCopter
  • haslinghuis
  • blckmn
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is minimal and does not follow the mandatory template structure. It lacks required sections including schematics review, hardware testing confirmation, guideline compliance, and the mandatory checklist. Replace the description with the required template and complete all mandatory sections including the compliance checklist, hardware testing confirmation, and guideline adherence statements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'DREAMWORKSH743 external I2C bus' directly relates to the main change, which moves the magnetometer from I2C bus 2 to bus 1, a hardware configuration update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ot0tot-patch-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis added the Bugfix Fixes a problem label Feb 6, 2026
@haslinghuis haslinghuis merged commit 6f041a4 into master Feb 6, 2026
5 checks passed
@haslinghuis haslinghuis deleted the ot0tot-patch-3 branch February 6, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants