Skip to content

GEPRC_TAKER_H743MINI - Fix PINIO1_CONFIG definition in config.h#991

Merged
haslinghuis merged 1 commit intomasterfrom
haslinghuis-patch-3
Dec 21, 2025
Merged

GEPRC_TAKER_H743MINI - Fix PINIO1_CONFIG definition in config.h#991
haslinghuis merged 1 commit intomasterfrom
haslinghuis-patch-3

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 21, 2025

Found during testing firmware builds

In file included from ./src/main/platform.h:30,
                 from ./src/main/drivers/bus_i2c_timing.c:23:
./src/config/configs/GEPRC_TAKER_H743MINI/config.h:117: error: "PINIO1_CONFIG" redefined [-Werror]
  117 | #define PINIO1_CONFIG 1
      | 
./src/config/configs/GEPRC_TAKER_H743MINI/config.h:116: note: this is the location of the previous definition
  116 | #define PINIO1_CONFIG                   129
      | 
In file included from ./src/main/platform.h:30,
                 from ./src/platform/STM32/debug.c:22:
./src/config/configs/GEPRC_TAKER_H743MINI/config.h:117: error: "PINIO1_CONFIG" redefined [-Werror]
  117 | #define PINIO1_CONFIG 1

Summary by CodeRabbit

  • Bug Fixes
    • Fixed GPIO pin configuration for the GEPRC_TAKER_H743MINI flight controller board. Corrected conflicting configuration values that affected pin I/O behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@haslinghuis haslinghuis self-assigned this Dec 21, 2025
@haslinghuis haslinghuis added the Bugfix Fixes a problem label Dec 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 21, 2025

Walkthrough

Resolves conflicting PINIO1_CONFIG macro definitions in the GEPRC_TAKER_H743MINI configuration header by consolidating duplicate definitions and changing the value from 129 to 1, establishing a single consistent configuration.

Changes

Cohort / File(s) Summary
Configuration macro correction
configs/GEPRC_TAKER_H743MINI/config.h
PINIO1_CONFIG macro value changed from 129 to 1; removed conflicting duplicate definitions

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • nerdCopter
  • blckmn
  • ot0tot

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides context about the build error but does not follow the required template for hardware controller submissions. Replace the current description with the required template sections including hardware compliance, checklist items, and mandatory review confirmation for this flight controller.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and accurately summarizes the main change: fixing the PINIO1_CONFIG definition in the config.h file for GEPRC_TAKER_H743MINI.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch haslinghuis-patch-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nerdCopter nerdCopter changed the title Fix PINIO1_CONFIG definition in config.h GEPRC_TAKER_H743MINI - Fix PINIO1_CONFIG definition in config.h Dec 21, 2025
@osirisinferi
Copy link
Contributor

With the new Config File Check action, these kinds of bugs shouldn't be possible any longer 🎉

@haslinghuis haslinghuis merged commit 4222e77 into master Dec 21, 2025
5 checks passed
@haslinghuis haslinghuis deleted the haslinghuis-patch-3 branch December 21, 2025 21:06
lukas-principiot pushed a commit to PrincipIoT/config that referenced this pull request Dec 27, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jan 5, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants