feat: add email support for legislative officials#150
Open
yaaabs wants to merge 13 commits intobettergovph:mainfrom
Open
feat: add email support for legislative officials#150yaaabs wants to merge 13 commits intobettergovph:mainfrom
yaaabs wants to merge 13 commits intobettergovph:mainfrom
Conversation
This reverts commit 9e43bad.
Collaborator
|
Thank you! Can we expand this further on other areas of the site? |
Contributor
Author
|
Thank you! Yes, I'd be happy to expand this to other areas. I can see email fields in the diplomaticc, constitutional, and executive directory data too. Should I create separate PRs for each area or one larger PR for all directories? I’ll resolve the mergr conflict first. |
Contributor
Author
|
merge conflict resolved |
angelofallars
requested changes
Sep 21, 2025
Member
There was a problem hiding this comment.
i am getting this error in /government/legislative/house-of-representatives-20th-congress:
[chamber].tsx:66 Uncaught ReferenceError: Mail is not defined
at [chamber].tsx:66:20
at Array.map (<anonymous>)
at LegislativeDetailSection ([chamber].tsx:58:31)
at react-stack-bottom-frame (react-dom_client.js?v=9591f5f4:17424:20)
at renderWithHooks (react-dom_client.js?v=9591f5f4:4206:24)
at updateFunctionComponent (react-dom_client.js?v=9591f5f4:6619:21)
at beginWork (react-dom_client.js?v=9591f5f4:7654:20)
at runWithFiberInDEV (react-dom_client.js?v=9591f5f4:1485:72)
at performUnitOfWork (react-dom_client.js?v=9591f5f4:10868:98)
at workLoopSync (react-dom_client.js?v=9591f5f4:10728:43)
...
Have you tested out this change in the browser yet?
| 'website', | ||
| 'email', | ||
| ]; | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
Fixed the missing semicolon
…e chamber component
…yaaabs/bettergov into refactor/remove-empty-classname
…refactor/remove-empty-classname
angelofallars
requested changes
Sep 22, 2025
Member
angelofallars
left a comment
angelofallars
left a comment
There was a problem hiding this comment.
on desktop there is some overflow (see last element)
|
Stale pull request message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Email Support for Legislative Officials
This PR adds missing email functionality to the legislative chamber pages.
Changes
Benefits
Impact