Skip to content

feat: add email support for legislative officials #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yaaabs wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: add email support for legislative officials #150

Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9e43bad
refactor(legislative): remove empty className and unused import
yaaabs Sep 21, 2025
914bf22
Revert "refactor(legislative): remove empty className and unused import"
yaaabs Sep 21, 2025
ada8f66
refactor(legislative): remove unused Mail import
yaaabs Sep 21, 2025
275db78
feat(legislative): add email support for legislative officials
yaaabs Sep 21, 2025
c8d56f7
Merge remote-tracking branch 'upstream/main' into refactor/remove-emp…
yaaabs Sep 21, 2025
b867c65
Merge branch 'main' into refactor/remove-empty-classname
yaaabs Sep 21, 2025
9cf5a2a
fix: add missing semicolon and improve typescript types in legislativ…
yaaabs Sep 21, 2025
8dd53bc
Merge branch 'refactor/remove-empty-classname' of https://github.com/…
yaaabs Sep 21, 2025
d8bb462
Merge branch 'main' of https://github.com/bettergovph/bettergov into …
yaaabs Sep 21, 2025
1cd7857
fix: add missing Mail import from lucide-react
yaaabs Sep 21, 2025
7d18920
Merge branch 'main' into refactor/remove-empty-classname
codegino Sep 22, 2025
acf11bc
refactor: make Secretariat Officials table responsive
yaaabs Sep 22, 2025
9cb6186
Merge branch 'main' into refactor/remove-empty-classname
yaaabs Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/pages/government/legislative/[chamber].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ function LegislativeDetailSection({
'address',
'trunkline',
'website',
'email',
]
Copy link
Member

@angelofallars angelofallars Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a semicolon here

Copy link
Contributor Author

@yaaabs yaaabs Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the missing semicolon


if (isSimpleObject) {
Expand All @@ -59,6 +58,23 @@ function LegislativeDetailSection({
{Object.entries(data).map(([key, value]) => {
if (skipKeys.includes(key) || value === undefined) return null

// Special handling for email fields
if (key === 'email' && value) {
return (
<div key={key} className="text-sm">
<div className="flex items-start">
<Mail className="h-4 w-4 text-gray-400 mr-2 mt-0.5 flex-shrink-0" />
<a
href={`mailto:${value}`}
className="text-primary-600 hover:underline leading-relaxed"
>
{String(value)}
</a>
</div>
</div>
)
}

return (
<div key={key} className="text-sm">
<span className="text-gray-800 leading-relaxed">
Expand Down