Miri is failing on latest nightly: pin nightly to last known working version#11421
Merged
mockersf merged 1 commit intobevyengine:mainfrom Jan 19, 2024
Merged
Miri is failing on latest nightly: pin nightly to last known working version#11421mockersf merged 1 commit intobevyengine:mainfrom
mockersf merged 1 commit intobevyengine:mainfrom
Conversation
mockersf
added
the
A-Build-System
hymm
approved these changes
Jan 19, 2024
mockersf
added
the
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
# Objective - Using the latest nightly for `miri` is generally desirable as we want to catch regressions upstream or new problems quickly - rust-lang/rust#120123 should be merged now, so it should work. ## Solution - Revert #11421. --------- Co-authored-by: François <mockersf@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution