use associated type bounds in QueryManyIter and QueryIter::sort()#14107
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jul 2, 2024
Merged
Conversation
Victoronz
added
A-ECS
Victoronz
force-pushed
the
simplify-query-iter-bounds
branch
from
dc6bdda to
3a82fa5
Compare
alice-i-cecile
approved these changes
Jul 2, 2024
janhohenheim
approved these changes
Jul 2, 2024
Member
janhohenheim
left a comment
janhohenheim
left a comment
There was a problem hiding this comment.
I personally like moving bounds to the where, but right now things are split between the impl line and the where line, so having at least all bounds consistently on the same line is an improvement in my book :)
janhohenheim
added
S-Ready-For-Final-Review
zmbush
pushed a commit
to zmbush/bevy
that referenced
this pull request
Jul 3, 2024
…vyengine#14107) # Objective The bounds for query iterators are quite intimidating. ## Solution With Rust 1.79, [associated type bounds](rust-lang/rust#122055) stabilized, which can simplify the bounds slightly.
MrGVSV
pushed a commit
to MrGVSV/bevy
that referenced
this pull request
Jul 5, 2024
…vyengine#14107) # Objective The bounds for query iterators are quite intimidating. ## Solution With Rust 1.79, [associated type bounds](rust-lang/rust#122055) stabilized, which can simplify the bounds slightly.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
# Objective Make the bounds for these query methods less intimidating. Continuation of #14107 <sub>My last pr was back in february 💀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The bounds for query iterators are quite intimidating.
Solution
With Rust 1.79, associated type bounds stabilized, which can simplify the bounds slightly.