[DRAFT] no_std Option for bevy_tasks#15362
Closed
bushrat011899 wants to merge 36 commits intobevyengine:mainfrom
Closed
[DRAFT] no_std Option for bevy_tasks#15362bushrat011899 wants to merge 36 commits intobevyengine:mainfrom
no_std Option for bevy_tasks#15362bushrat011899 wants to merge 36 commits intobevyengine:mainfrom
Conversation
Cannot rely on call-sites having `extern crate alloc;`. Perhaps `bevy_ecs` could re-export `Box` for this macro, but `std` is fine for now.
We wish to use different lints for the examples, and `cargo` currently doesn't support overriding workspace lints within a crate. As a workaround, all workspace lints are duplicated for the root crate to allow it to specifically allow the standard library.
Explains the requirement for duplicating the lints as a form of workspace overrides
Co-Authored-By: François Mockers <francois.mockers@vleue.com>
Co-Authored-By: François Mockers <francois.mockers@vleue.com>
Co-Authored-By: François Mockers <francois.mockers@vleue.com>
However, `bevy_ptr` and `bevy_utils` must still link to `core` and `alloc` due to the possibility of being `no_std` based on feature gating.
alice-i-cecile
added
C-Usability
bushrat011899
force-pushed
the
NoSTDBevyTasks
branch
4 times, most recently
from
47dcef8 to
2f345b3
Compare
bushrat011899
force-pushed
the
NoSTDBevyTasks
branch
from
da31142 to
5312ab9
Compare
bushrat011899
force-pushed
the
NoSTDBevyTasks
branch
2 times, most recently
from
ff778c1 to
032bbde
Compare
bushrat011899
force-pushed
the
NoSTDBevyTasks
branch
from
032bbde to
6e20849
Compare
Contributor
Author
|
Closed in favour of #15464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_tasksinno_stdcontextsSolution
async_executorbased on existing reference implementation but usingspinsync primitives, allowingno_stdusage.TaskPoolusing a single globalExecutorTesting
Notes
bevy_ecsneeds work to permit a minimalno_stdBevy application, asbevy_appis triviallyno_stdonce these two crates are.Syncrequirements required in ano_stdcontext. Also, I'm waiting for the lints in AddcoreandallocoverstdLints #15281 to be merged, as this work is based off of some of those changes (hence the absurdly high change count)