Conversation
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
|
@alice-i-cecile But I provided a migration guide. Probably the label was added by accident. |
Might have been a bit out of date: migration guides now go in tree under the |
|
Ah, I didn't know! Will add once |
|
Just to jot this down somewhere: we're currently using |
|
There are many places where But looks like tracing won't be released in time for 0.17 😢 |
Currently requires a new release of `tracing-subscriber`. Once released, 2 lines needs to be uncommented in `Cargo.toml`, see `TODO`.
c39807d to
c7de4ab
Compare
|
Updated to 0.18, but I'm still waiting for a new release: tokio-rs/tracing#3413 (comment) |
Objective
bevy_loginno_std#18782, which was reverted in Revert "Allow partial support forbevy_loginno_std(#18782)" #18816. This time with properno_stdsupport.@bushrat011899's work on adding portable-atomic support was merged. I saw that this was backported in tokio-rs/tracing#3283 and started working on the PR. Then I realized the release hadn’t been drafted yet: tokio-rs/tracing#3282 😢
Keeping this PR as a draft for now - it only requires uncommenting 2 lines once the release drops (see the
TODOinbevy_log's Cargo.toml).Solution
std,web, andcritical-sectiontobevy_log.portable-atomicinbevy_log, similar to other crates.bevy_lognon-optional. It became optional after theno_stdmigration (Addno_stdsupport tobevy#17955) because it requiredstd. In the original attempt (Allow partial support forbevy_loginno_std#18782), it was also made non-optional.Testing
Migration Guide
bevy_logwith default features disabled, enable the newstdfeature.bevy_logfeature, remove it.