Skip to content

Move allow unsafe_op_in_unsafe_fn to module level in bevy_ecs #22134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 8 commits into from
Dec 19, 2025
Merged

Move allow unsafe_op_in_unsafe_fn to module level in bevy_ecs #22134

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a9ed99
move lint exception to module and file level instead of crate
hymm Dec 2, 2025
e017aee
add another for new unsafe
hymm Dec 15, 2025
4a1e221
add for multithreaded executor
hymm Dec 15, 2025
a445a53
add dodgy safety comment for dodgy hot patching
hymm Dec 15, 2025
070aebf
slightly less dodgy safety comment
hymm Dec 16, 2025
9569011
Merge remote-tracking branch 'upstream/main' into move-allow-to-modue…
hymm Dec 18, 2025
b131081
change safety comment to expect to emphasize possible UB
hymm Dec 18, 2025
daebd86
remove now unneeded expect and deny
hymm Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/bevy_ecs/src/schedule/executor/multi_threaded.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,9 @@ impl ExecutorState {
}

#[cfg(feature = "hotpatching")]
// SAFETY: No system should mutate `HotPatchChanges`
// SAFETY: This operation is not safe. It could create UB if a user creates a mutable reference
// to `HotPatchChanges` in a system. But this can only happen when the `hotpatching` feature is
// enabled.
let hotpatch_tick = unsafe {
context
.environment
Expand Down