Skip to content

Add ConditionalSendStream trait #22185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stevehello166 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ConditionalSendStream trait #22185

stevehello166 wants to merge 1 commit into from
+7 −0

Conversation

@stevehello166
Copy link
Contributor

@stevehello166 stevehello166 commented Dec 18, 2025

Objective

Resolves #22093

Solution

Add the trait the author proposed.

Testing

  • Did you test these changes? If so, how?
    No as the trait did not appear to need testing and I found no tests relating to the ConditionalSendFuture sister trait.

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds O-Web Specific to web (WASM) builds S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Tasks Tools for parallel and async work and removed A-Assets Load files from disk to use for things like images, models, and sounds labels Dec 18, 2025
@hymm
Copy link
Contributor

hymm commented Dec 18, 2025

ConditionalSendFuture is used internally, so doesn't need a test. I'd at least like to see someone test this with a stream that is conditionally send between web and native. Does this need to be in tree to enable interop between different bevy libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds A-Tasks Tools for parallel and async work O-Web Specific to web (WASM) builds S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ConditionalSendStream to match ConditionalSendFuture

3 participants

@stevehello166 @hymm @alice-i-cecile