Skip to content

Enable primitive restart by default #22188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
beicause wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enable primitive restart by default #22188

beicause wants to merge 4 commits into from
+192 −57

Conversation

@beicause
Copy link
Contributor

@beicause beicause commented Dec 18, 2025

Objective

Depends on #22187. Fixes #17794. For platform consistency I think it’s reasonable to enable primitive restart by default.

Solution

Add index format to MeshPipelineKey, replace MeshPipelineKey::from_primitive_topology with MeshPipelineKey::from_primitive_topology_and_index, and enable strip_index_format in render pipeline.

Testing

Run lines example

Showcase

Click to view showcase 屏幕截图_20251218_210849

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StandardMaterial doesn't support primitive restart

2 participants

@beicause @alice-i-cecile