Skip to content

Fix 3d gizmo pipeline when atmosphere present #22190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mate-h wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 3d gizmo pipeline when atmosphere present #22190

mate-h wants to merge 1 commit into from
+7 −2

Conversation

@mate-h
Copy link
Contributor

@mate-h mate-h commented Dec 18, 2025

Objective

Solution

  • Add missing atmosphere pipeline key in the gizmo pipeline.

Testing

  • Ran the 3d gizmo example with local changes to add the atmosphere to the camera and a directional light

Showcase

Screenshot 2025-12-18 at 1 15 53 PM

@mate-h mate-h requested a review from ecoskey December 18, 2025 21:17
@mate-h mate-h added C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 18, 2025
@mate-h mate-h added this to the 0.18 milestone Dec 18, 2025
@alice-i-cecile alice-i-cecile added the A-Rendering Drawing game state to the screen label Dec 18, 2025
@JMS55 JMS55 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@JMS55 JMS55 JMS55 approved these changes

@ecoskey ecoskey ecoskey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: No status

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

Atmosphere with Gizmos is broken

4 participants

@mate-h @JMS55 @ecoskey @alice-i-cecile