Skip to content

Add Dir2::from_angle #22197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lynn-lumen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Dir2::from_angle #22197

lynn-lumen wants to merge 1 commit into from
+6 −0

Conversation

@lynn-lumen
Copy link
Contributor

@lynn-lumen lynn-lumen commented Dec 19, 2025

Objective

  • I have found myself writing Dir2::new_unchecked(Vec2::from_angle(angle)) or Dir2::new(Vec2::from_angle(angle)).unwrap() quite frequently. This is pretty cumbersome and should not require calling .unwrap() or unchecked functions.

Solution

  • Added Dir2::from_angle(angle)

@lynn-lumen lynn-lumen changed the title impl Dir2 from_angle Add Dir2::from_angle Dec 19, 2025
@andriyDev andriyDev added C-Feature A new feature, making something new possible A-Math Fundamental domain-agnostic mathematical operations D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 21, 2025
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@andriyDev andriyDev andriyDev approved these changes

@vidanm vidanm vidanm approved these changes

@Hilpogar Hilpogar Hilpogar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lynn-lumen @andriyDev @vidanm @Hilpogar