Skip to content

Conversation

@ickshonpe
Copy link
Contributor

Objective

Modify the testbed_ui text scenes so it will catch bugs like #22191

Solution

Add new cases to testbed_ui's text scene displaying multiple text sections with different fonts and weights with spaces and without spaces.

Showcase

Screenshot 2025-12-19 142112

@github-actions
Copy link
Contributor

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-22198

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered labels Dec 19, 2025
Copy link
Contributor

@pablo-lua pablo-lua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-lua pablo-lua added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 19, 2025
Copy link
Contributor

@rossleonardy rossleonardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, ++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Text Rendering and layout for characters C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants