Skip to content

Fix separate layers with lines and joints #22199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yh1970 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix separate layers with lines and joints #22199

yh1970 wants to merge 1 commit into from
+21 −49

Conversation

@yh1970
Copy link

@yh1970 yh1970 commented Dec 19, 2025

Objective

Fix #22179

Solution

Merge the two queue systems into one. The line and joint pairs should be drawn now in their own layers.

Testing

I ran the 2d_gizmos example.

Showcase

Click to view showcase

Before

Screenshot 2025-12-19 at 17 35 59

After

Screenshot 2025-12-19 at 17 35 24

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@pablo-lua pablo-lua added C-Bug An unexpected or incorrect behavior A-Gizmos Visual editor and debug gizmos D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 19, 2025
pablo-lua
pablo-lua approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@pablo-lua pablo-lua left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much a straightforward fix. Tested bevy_2d examples, looks like it`s working good. Thanks for your contribution

kfc35
kfc35 approved these changes Dec 20, 2025
View reviewed changes
Copy link
Contributor

@kfc35 kfc35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this on my MacOS and it works as intended
Logic looks good (not too familiar with gizmo logic stuff though!)

@pablo-lua pablo-lua added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kfc35 kfc35 kfc35 approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Gizmos Visual editor and debug gizmos C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Strange clipping in joints in gizmos example

3 participants

@yh1970 @kfc35 @pablo-lua