Skip to content

impl VisitAssetDependencies for bevy_platform::collections::HashMap #22211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Strikeless wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −1
Open

impl VisitAssetDependencies for bevy_platform::collections::HashMap #22211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion crates/bevy_asset/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ use bevy_ecs::{
schedule::{IntoScheduleConfigs, SystemSet},
world::FromWorld,
};
use bevy_platform::collections::HashSet;
use bevy_platform::collections::{HashMap, HashSet};
use bevy_reflect::{FromReflect, GetTypeRegistration, Reflect, TypePath};
use core::any::TypeId;
use tracing::error;
Expand Down Expand Up @@ -548,6 +548,22 @@ impl VisitAssetDependencies for HashSet<UntypedHandle> {
}
}

impl<K, A: Asset> VisitAssetDependencies for HashMap<K, Handle<A>> {
fn visit_dependencies(&self, visit: &mut impl FnMut(UntypedAssetId)) {
for dependency in self.values() {
visit(dependency.id().untyped());
}
}
}

impl<K> VisitAssetDependencies for HashMap<K, UntypedHandle> {
fn visit_dependencies(&self, visit: &mut impl FnMut(UntypedAssetId)) {
for dependency in self.values() {
visit(dependency.id());
}
}
}

/// Adds asset-related builder methods to [`App`].
pub trait AssetApp {
/// Registers the given `loader` in the [`App`]'s [`AssetServer`].
Expand Down Expand Up @@ -2030,6 +2046,10 @@ mod tests {
set_handles: HashSet<Handle<TestAsset>>,
#[dependency]
untyped_set_handles: HashSet<UntypedHandle>,
#[dependency]
map_handles: HashMap<(), Handle<TestAsset>>,
#[dependency]
untyped_map_handles: HashMap<(), UntypedHandle>,
},
StructStyle(#[dependency] TestAsset),
Empty,
Expand All @@ -2053,6 +2073,10 @@ mod tests {
set_handles: HashSet<Handle<TestAsset>>,
#[dependency]
untyped_set_handles: HashSet<UntypedHandle>,
#[dependency]
map_handles: HashMap<(), Handle<TestAsset>>,
#[dependency]
untyped_map_handles: HashMap<(), UntypedHandle>,
}

#[expect(
Expand Down