-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Make LoadContext::finish add all dependencies, and avoid a second texture load in GltfLoader.
#22227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andriyDev
wants to merge
8
commits into
bevyengine:main
Choose a base branch
from
andriyDev:gltf-one-load
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+430
−363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2b68a3 to
5b5297a
Compare
ChristopherBiscardi
approved these changes
Dec 22, 2025
Contributor
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read through the code and it all seems reasonable to me. +100 on the deduplication.
… if not loaded through their load context.
…just clone texture handles.
5b5297a to
a2a4e67
Compare
mockersf
reviewed
Dec 24, 2025
mockersf
reviewed
Dec 24, 2025
mockersf
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Assets
Load files from disk to use for things like images, models, and sounds
A-glTF
Related to the glTF 3D scene/model format
C-Refinement
Improves output quality, without fixing a clear bug or adding new functionality.
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
LoadContext.StandardMaterialwere missing the#[dependency]attribute.Solution
StandardMaterial.parse_material_extension_texturefunction like all the other extensions (the existing implementation matched exactly).LoadContext::finishupdate the list of dependencies withVisitDependencies.GltfLoaderand clone the handle out when necessary.Testing
bevy_assetto verify tracking dependencies works - this also fails before the rest of this PR.load_gltfexample and it still works. This won't show whether the dependency tracking works correctly though.