Skip to content

Directional navigation uses edge to edge distance not center to center #22241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
apekros wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Directional navigation uses edge to edge distance not center to center #22241

apekros wants to merge 1 commit into from
+53 −4

Conversation

@apekros
Copy link
Contributor

@apekros apekros commented Dec 23, 2025

Objective

The situation this addresses was kindly diagrammed out by @ickshonpe:

Details image
The closer item to navigate to is the wider rectangle, but as the center is further away, the bottom rectangle would be chosen, which is incorrect.

Solution

This change does edge to edge distance instead of center to center. I have left alignment scoring to use center to center direction but happy to change this too, I was unsure!

Testing

Added a test for the scenario diagrammed above.

@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Dec 23, 2025
@ickshonpe ickshonpe added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets A-App Bevy apps and plugins S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed A-App Bevy apps and plugins labels Dec 23, 2025
@ickshonpe ickshonpe self-requested a review December 23, 2025 09:23
@ickshonpe
Copy link
Contributor

ickshonpe commented Dec 23, 2025

Going to be out today, but I'll try and find time for a review this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ickshonpe ickshonpe Awaiting requested review from ickshonpe

Assignees

No one assigned

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

3 participants

@apekros @ickshonpe @alice-i-cecile