Rework FloatOrd with total_cmp() and hash by bits #22248
+8
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
IQuick143
added
A-Math
Member
|
I tried this some years ago when it was stabilised, and it had negative performance impacts. Could you check? |
mockersf
added
the
S-Needs-Benchmarking
Author
Is there a specific area where this caused problems, or a specific means I should use for benching? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5152.
Solution
Use
f32::total_cmp()for ordering andf32::to_bits()for hashing.Testing
Tested via existing unit tests. This may impact several parts of the engine which use
FloatOrdfor sorting, as sorting ofNaNs has changed. These paths have not been tested.Notes
This is a potentially significant behavioral change for
FloatOrdand should likely be included in a breaking release if accepted.