Skip to content

fix decal index selection in light textures #22267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChristopherBiscardi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix decal index selection in light textures #22267

ChristopherBiscardi wants to merge 1 commit into from
+3 −3

Conversation

@ChristopherBiscardi
Copy link
Contributor

@ChristopherBiscardi ChristopherBiscardi commented Dec 25, 2025

Objective

#22039 changed how many images are associated with a decal. light textures use decal base textures, ignoring the others.

fixes #22266

Solution

use base color texture index

Testing

cargo run --example light_textures --features="pbr_light_textures"

Showcase

before

screenshot-2025-12-25-at-08 53 17@2x

after

screenshot-2025-12-25-at-08 57 26@2x

@ChristopherBiscardi ChristopherBiscardi added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 25, 2025
@ChristopherBiscardi ChristopherBiscardi added this to the 0.18 milestone Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Firesz25 Firesz25 Firesz25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: No status

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

Light Texture shader is broken in 0.18.0-rc.1

2 participants

@ChristopherBiscardi @Firesz25