Skip to content

AutoNavigationConfig::max_search_distance fix #22278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 2 commits into from
Dec 31, 2025
Merged

AutoNavigationConfig::max_search_distance fix #22278

alice-i-cecile merged 2 commits into from
Dec 31, 2025

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 26, 2025 •
edited
Loading

Objective

Automatic directional navigation ignores scale factor.

Fixes #22277

Solution

Multiply the size and translation of each FocusableArea by the inverse scale factor.

@ickshonpe
AutoNavigationConfig::max_search_distance is meant to be a logical …
8ca4033 
…distance but `auto_rebuild_ui_navigation_graph` ignores scale factor and interprets it as a physical value. This means that nodes that should be connected by a navigation path may not be connected on monitors with a higher scale factor.

This change adjusts the translation and size of each `FocusableArea` so that scale factor is respected.
@ickshonpe ickshonpe added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 26, 2025
@ickshonpe ickshonpe added this to the 0.18 milestone Dec 26, 2025
@ickshonpe ickshonpe added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 29, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 30, 2025
@brianreavis brianreavis mentioned this pull request Dec 30, 2025
Closed
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Dec 30, 2025

Let me know when conflicts are resolved :)

@ickshonpe
Copy link
Contributor Author

ickshonpe commented Dec 30, 2025

Let me know when conflicts are resolved :)

Should be good now.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 31, 2025
Merged via the queue into bevyengine:main with commit f6165ba Dec 31, 2025
38 checks passed
cart pushed a commit that referenced this pull request Jan 8, 2026
@ickshonpe @cart
AutoNavigationConfig::max_search_distance fix (#22278)
460adf8 
# Objective

Automatic directional navigation ignores scale factor.

Fixes #22277

## Solution

Multiply the size and translation of each `FocusableArea` by the inverse
scale factor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@viridia viridia viridia approved these changes

@kfc35 kfc35 kfc35 approved these changes

@Firesz25 Firesz25 Firesz25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

bevy_input_focus: Auto navigation ignores scale factor

5 participants

@ickshonpe @alice-i-cecile @viridia @kfc35 @Firesz25