Always present at least once for new windows. #22307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
added
A-Rendering
alice-i-cecile
approved these changes
Dec 29, 2025
Contributor
|
With my tiling window manager on Wayland it does indeed spawn the window fixing the problem but it does look a little goofy. 
Rather than the entire window being the clear color as it would typically be it's letterbox-ed up inside the window. I don't think this is an issue at all since if you do add a camera it does what you would normally expect. For my use case, it's perfectly fine but figured I would post my experience for completeness. |
it-me-joda
approved these changes
Dec 29, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Closes #22306. In theory we could cfg gate this for just wayland but doesn't seem harmful to do as a general case so nbd imo. Don't have access to wayland right now so can't test but the docs [here](https://wayland.app/protocols/xdg-shell#xdg_surface) and [here](https://wayland-book.com/surfaces-in-depth/lifecycle.html) seem to confirm this is the right fix.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Closes #22306. In theory we could cfg gate this for just wayland but doesn't seem harmful to do as a general case so nbd imo. Don't have access to wayland right now so can't test but the docs [here](https://wayland.app/protocols/xdg-shell#xdg_surface) and [here](https://wayland-book.com/surfaces-in-depth/lifecycle.html) seem to confirm this is the right fix.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Closes #22306. In theory we could cfg gate this for just wayland but doesn't seem harmful to do as a general case so nbd imo. Don't have access to wayland right now so can't test but the docs [here](https://wayland.app/protocols/xdg-shell#xdg_surface) and [here](https://wayland-book.com/surfaces-in-depth/lifecycle.html) seem to confirm this is the right fix.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Closes #22306. In theory we could cfg gate this for just wayland but doesn't seem harmful to do as a general case so nbd imo. Don't have access to wayland right now so can't test but the docs [here](https://wayland.app/protocols/xdg-shell#xdg_surface) and [here](https://wayland-book.com/surfaces-in-depth/lifecycle.html) seem to confirm this is the right fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22306. In theory we could cfg gate this for just wayland but doesn't seem harmful to do as a general case so nbd imo.
Don't have access to wayland right now so can't test but the docs here and here seem to confirm this is the right fix.