Update cosmic-text to 0.16 #22308
Merged
Update cosmic-text to 0.16 #22308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mapped to cosmic-text's indentical `Hinting` enum. `Text` requires `FontHinting::Enabled`, `Text2d` requires `FontHinting::Disabled`.
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
ickshonpe
added
A-Text
JMS55
approved these changes
Dec 30, 2025
james7132
approved these changes
Dec 30, 2025
it-me-joda
approved these changes
Dec 31, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
cart
pushed a commit
that referenced
this pull request
Jan 8, 2026
# Objective Update the Cosmic Text dependency to 0.16. Fixes #22191 ## Solution There aren't any breaking changes with Cosmic Text version 0.16, but it does add font-hinting support. This is controlled in Bevy with a new component `FontHinting`. The `Text` component, which is normally used with physical pixel aligned text, now requires `FontHinting::Enabled`, and `Text2d`, which normally isn't pixel aligned, now requires `FontHinting::Disabled`. Hinting needs to be set per text block, not per text span entity, so it wouldn't be appropriate to add it as a field on `TextFont`. ## Testing `testbed_ui`'s text scene in main with cosmic-text 15: <img width="1924" height="1127" alt="cosmic-15" src="https://github.com/user-attachments/assets/0ee44e38-07b0-411b-9102-b7d28de0ffcd" /> The font names are meant to be rendered in their corresponding fonts but, as you can see, some names are rendered using the incorrect font. This is due to the ascii fastpath bug in cosmic-text 15, which is fixed in 16. `testbed_ui`'s text scene on this branch with cosmic-text 16: <img width="1924" height="1127" alt="cosmic-16" src="https://github.com/user-attachments/assets/549f9a21-e24d-422d-a9e2-eac902b2e054" /> Now each font's name is rendered using the correct font.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Update the Cosmic Text dependency to 0.16.
Fixes #22191
Solution
There aren't any breaking changes with Cosmic Text version 0.16, but it does add font-hinting support. This is controlled in Bevy with a new component
FontHinting. TheTextcomponent, which is normally used with physical pixel aligned text, now requiresFontHinting::Enabled, andText2d, which normally isn't pixel aligned, now requiresFontHinting::Disabled. Hinting needs to be set per text block, not per text span entity, so it wouldn't be appropriate to add it as a field onTextFont.Testing
testbed_ui's text scene in main with cosmic-text 15:The font names are meant to be rendered in their corresponding fonts but, as you can see, some names are rendered using the incorrect font. This is due to the ascii fastpath bug in cosmic-text 15, which is fixed in 16.
testbed_ui's text scene on this branch with cosmic-text 16:Now each font's name is rendered using the correct font.