Solari: Specular path spread heuristic #22311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
added
A-Rendering
SparkyPotato
suggested changes
Dec 30, 2025
ChristopherBiscardi
approved these changes
Dec 30, 2025
SparkyPotato
approved these changes
Dec 30, 2025
JMS55
added
the
S-Ready-For-Final-Review
alice-i-cecile
added
the
C-Refinement
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Currently solari's specular GI conditionally terminates in the world cache based on the roughness of a surface. This PR changes that. Now, solari tracks the spread of the full path to the camera, and terminates in the world cache once the spread is wide enough. On the plus side this gives * A good bit better performance * More stable / higher quality lighting sometimes On the downside: * Transitions between world cache LODs tend to show up in rough reflections. Unlike ReSTIR GI, there's currently no temporal reservoirs to hide it. * Slightly more light leaks / less accuracy sometimes Overall I think it's a worthwhile change.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Currently solari's specular GI conditionally terminates in the world cache based on the roughness of a surface. This PR changes that. Now, solari tracks the spread of the full path to the camera, and terminates in the world cache once the spread is wide enough. On the plus side this gives * A good bit better performance * More stable / higher quality lighting sometimes On the downside: * Transitions between world cache LODs tend to show up in rough reflections. Unlike ReSTIR GI, there's currently no temporal reservoirs to hide it. * Slightly more light leaks / less accuracy sometimes Overall I think it's a worthwhile change.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Currently solari's specular GI conditionally terminates in the world cache based on the roughness of a surface. This PR changes that. Now, solari tracks the spread of the full path to the camera, and terminates in the world cache once the spread is wide enough. On the plus side this gives * A good bit better performance * More stable / higher quality lighting sometimes On the downside: * Transitions between world cache LODs tend to show up in rough reflections. Unlike ReSTIR GI, there's currently no temporal reservoirs to hide it. * Slightly more light leaks / less accuracy sometimes Overall I think it's a worthwhile change.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Currently solari's specular GI conditionally terminates in the world cache based on the roughness of a surface. This PR changes that. Now, solari tracks the spread of the full path to the camera, and terminates in the world cache once the spread is wide enough. On the plus side this gives * A good bit better performance * More stable / higher quality lighting sometimes On the downside: * Transitions between world cache LODs tend to show up in rough reflections. Unlike ReSTIR GI, there's currently no temporal reservoirs to hide it. * Slightly more light leaks / less accuracy sometimes Overall I think it's a worthwhile change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently solari's specular GI conditionally terminates in the world cache based on the roughness of a surface.
This PR changes that. Now, solari tracks the spread of the full path to the camera, and terminates in the world cache once the spread is wide enough.
On the plus side this gives
On the downside:
Overall I think it's a worthwhile change.