Specular GI MIS #22313
Merged
Specular GI MIS #22313
+31
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkyPotato
added
S-Needs-Review
SparkyPotato
force-pushed
the
specular-gi-mis
branch
from
b8a39a5 to
b36120c
Compare
JMS55
suggested changes
Dec 30, 2025
JMS55
reviewed
Dec 30, 2025
Co-authored-by: JMS55 <[email protected]>
JMS55
reviewed
Dec 30, 2025
JMS55
approved these changes
Dec 30, 2025
alice-i-cecile
approved these changes
Dec 30, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
JMS55
approved these changes
Dec 30, 2025
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
ReSTIR DI (and other DI algorithms) can't find light samples that align well with very smooth, specular surfaces. However, specular GI does a trace for these surfaces, which we can use to improve DI. This PR uses the specular GI trace to light the specular lobe for smooth surfaces, disabling DI on the specular lobe for them. This PR: <img width="1920" height="1032" alt="image" src="https://github.com/user-attachments/assets/d7768779-6a57-4226-8d36-eefaf2a27df1" /> Previously: <img width="1920" height="1032" alt="image" src="https://github.com/user-attachments/assets/5b408160-a384-4f4b-8ae4-3c89812f75d3" /> Reference: <img width="1920" height="1032" alt="image" src="https://github.com/user-attachments/assets/089fdec5-17a4-4277-87b2-dd6d271ba1f6" /> --------- Co-authored-by: JMS55 <[email protected]>
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
ReSTIR DI (and other DI algorithms) can't find light samples that align well with very smooth, specular surfaces. However, specular GI does a trace for these surfaces, which we can use to improve DI. This PR uses the specular GI trace to light the specular lobe for smooth surfaces, disabling DI on the specular lobe for them. This PR: <img width="1920" height="1032" alt="image" src="https://github.com/user-attachments/assets/d7768779-6a57-4226-8d36-eefaf2a27df1" /> Previously: <img width="1920" height="1032" alt="image" src="https://github.com/user-attachments/assets/5b408160-a384-4f4b-8ae4-3c89812f75d3" /> Reference: <img width="1920" height="1032" alt="image" src="https://github.com/user-attachments/assets/089fdec5-17a4-4277-87b2-dd6d271ba1f6" /> --------- Co-authored-by: JMS55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReSTIR DI (and other DI algorithms) can't find light samples that align well with very smooth, specular surfaces. However, specular GI does a trace for these surfaces, which we can use to improve DI.
This PR uses the specular GI trace to light the specular lobe for smooth surfaces, disabling DI on the specular lobe for them.
This PR:
Previously:
Reference:
