Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
ray_mesh_intersection<T>()does not care about the indices type, so anyTryInto<usize>will do.ray_mesh_intersection<T>(withT=usize) when any of the existing one will do, we get a small improvement in code size (and presumably compilation time as well).Testing
mesh_ray_castexample, which works as expectedThe gain is indeed small (0.8kB in dev, 3kB in release and noise (4B) in size-optimized builds)
Showcase
cargo bloatis used to visualize the differences. Profile dev confirms that one less instance of the function is generated:In release the function is inlined into
ray_intersection_over_mesh()which gains 3kB: