Fix: Closes shapes for 3d gizmos #22317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
3d_gizmosdoesn't have closed shapes #22204Solution
lineloopdelegate to the 3d one.linestripto uselineloop(rect andGizmoPrimitive3d<Triangle3d>).GizmoPrimitive3d<Polyline3d>, cube(), and aabb3d() still uselinestrip. As far as I could tell, the cube looked ok for all corners in the3d_gizmosexample (the black cube in the center of the scene) but another pair of eyes could be helpful there.Testing
cargo run --example 3d_gizmos --features=free_cameraand saw that the green 3d square gizmo now closesTriangle3dand verified thatTriangle3dnow closesModified Demo for Triangle 3d
Before (notice notch in bottom left hand corner):

After (notch in bottom left hand corner is gone):
