-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Reorganize some of bevy_reflect's exports into their respective modules
#22342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reorganize some of bevy_reflect's exports into their respective modules
#22342
Conversation
01d74c9 to
27bed7c
Compare
91fc332 to
c2eaec0
Compare
84c7a8d to
20552cf
Compare
20552cf to
59c9ebf
Compare
44a4933 to
3c65b6d
Compare
it-me-joda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like some pretty nice and thorough reorganization. Aside from cleanliness, is there an additional benefit you are trying to capture with moving things around?
janhohenheim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't inspect these tooooooo deeply, but it looks good :)
The main point is to make it clear what items belong to what type of reflected item, which in turn helps to avoid overwhelming users. So no, not really - the cleanliness is the main point, that ends up causing other (beneficial) effects. |
|
Per my request, MrGVSV has been requested to review this, as he's the reflection SME. Though if any maintainers want to merge without his review, feel free. I just think, since I've been communicating with him a bit while planning and making this PR, it'd be worth requesting his review. |
In case you want to inspect more deeply, here's the files you'd be most interested in:
Pretty much everything else is changes to typepaths themselves (usually |
Objective
bevy_reflect's exports to de-clutter the crate root #22321Solution
Do it
Testing
cargo clippyand CI.