Skip to content

bevy_ui_debug scrollbars inset fix #22343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ickshonpe wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −40
Open

bevy_ui_debug scrollbars inset fix #22343

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b92cd9
Problem: `ComputedNode`'s `content_inset` field was changed so the sp…
ickshonpe Jan 1, 2026
be578f4
Merge branch 'main' into ui-debug-overlay-scrollbars-fix
ickshonpe Jan 1, 2026
5fcbb94
Merge branch 'main' into ui-debug-overlay-scrollbars-fix
ickshonpe Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 16 additions & 40 deletions crates/bevy_ui_render/src/debug_overlay.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,49 +178,25 @@ pub fn extract_debug_overlay(
}

if debug_options.outline_scrollbars {
if 0. <= uinode.scrollbar_size.y {
let content_inset = uinode.content_inset();
let half_size = 0.5 * uinode.size;
let min_x = -half_size.x + content_inset.min_inset.x;
let max_x = half_size.x - content_inset.max_inset.x - uinode.scrollbar_size.x;
let max_y = half_size.y - content_inset.max_inset.y;
let min_y = max_y - uinode.scrollbar_size.y;
let gutter = Rect {
min: Vec2::new(min_x, min_y),
max: Vec2::new(max_x, max_y),
};
let gutter_length = gutter.size().x;
let thumb_min =
gutter.min.x + gutter_length * uinode.scroll_position.x / uinode.content_size.x;
let thumb_max = thumb_min + gutter_length * gutter_length / uinode.content_size.x;
let thumb = Rect {
min: Vec2::new(thumb_min, gutter.min.y),
max: Vec2::new(thumb_max, gutter.max.y),
};
if let Some((gutter, [thumb_min, thumb_max])) = uinode.horizontal_scrollbar() {
push_outline(gutter, ResolvedBorderRadius::ZERO);
push_outline(thumb, ResolvedBorderRadius::ZERO);
push_outline(
Rect {
min: Vec2::new(thumb_min, gutter.min.y),
max: Vec2::new(thumb_max, gutter.max.y),
},
ResolvedBorderRadius::ZERO,
);
}
if 0. <= uinode.scrollbar_size.x {
let content_inset = uinode.content_inset();
let half_size = 0.5 * uinode.size;
let max_x = half_size.x - content_inset.max_inset.x;
let min_x = max_x - uinode.scrollbar_size.x;
let min_y = -half_size.y + content_inset.min_inset.y;
let max_y = half_size.y - content_inset.max_inset.y - uinode.scrollbar_size.y;
let gutter = Rect {
min: Vec2::new(min_x, min_y),
max: Vec2::new(max_x, max_y),
};
let gutter_length = gutter.size().y;
let thumb_min =
gutter.min.y + gutter_length * uinode.scroll_position.y / uinode.content_size.y;
let thumb_max = thumb_min + gutter_length * gutter_length / uinode.content_size.y;
let thumb = Rect {
min: Vec2::new(gutter.min.x, thumb_min),
max: Vec2::new(gutter.max.x, thumb_max),
};
if let Some((gutter, [thumb_min, thumb_max])) = uinode.vertical_scrollbar() {
push_outline(gutter, ResolvedBorderRadius::ZERO);
push_outline(thumb, ResolvedBorderRadius::ZERO);
push_outline(
Rect {
min: Vec2::new(gutter.min.x, thumb_min),
max: Vec2::new(gutter.max.x, thumb_max),
},
ResolvedBorderRadius::ZERO,
);
}
}
}
Expand Down