Skip to content

use seeded rng for dynamic_mip_generation #22346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mockersf merged 1 commit into from
Jan 2, 2026
Merged

use seeded rng for dynamic_mip_generation #22346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions examples/2d/dynamic_mip_generation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ use bevy::{
sprite_render::{AlphaMode2d, Material2d, Material2dPlugin},
window::{PrimaryWindow, WindowResized},
};
use rand::{rngs::ThreadRng, Rng};
use rand::{Rng, SeedableRng};
use rand_chacha::ChaCha8Rng;

use crate::widgets::{
RadioButton, RadioButtonText, WidgetClickEvent, WidgetClickSender, BUTTON_BORDER,
Expand Down Expand Up @@ -68,6 +69,8 @@ struct AppStatus {
image_width: ImageSize,
/// The height of the image.
image_height: ImageSize,
/// Seeded random generator.
rng: ChaCha8Rng,
}

impl Default for AppStatus {
Expand All @@ -76,6 +79,7 @@ impl Default for AppStatus {
enable_mip_generation: EnableMipGeneration::On,
image_width: ImageSize::Size640,
image_height: ImageSize::Size480,
rng: ChaCha8Rng::seed_from_u64(19878367467713),
}
}
}
Expand Down Expand Up @@ -537,7 +541,7 @@ fn regenerate_image_when_requested(
image_views_query: Query<Entity, With<ImageView>>,
windows_query: Query<&Window, With<PrimaryWindow>>,
app_assets: Res<AppAssets>,
app_status: Res<AppStatus>,
mut app_status: ResMut<AppStatus>,
mut images: ResMut<Assets<Image>>,
mut single_mip_level_materials: ResMut<Assets<SingleMipLevelMaterial>>,
mut color_materials: ResMut<Assets<ColorMaterial>>,
Expand Down Expand Up @@ -750,7 +754,7 @@ impl AppStatus {

/// Regenerates the main image based on the image size selected by the user.
fn regenerate_mipmap_source_image(
&self,
&mut self,
commands: &mut Commands,
images: &mut Assets<Image>,
) -> Handle<Image> {
Expand Down Expand Up @@ -779,11 +783,10 @@ impl AppStatus {
/// Draws the concentric ellipses that make up the image.
///
/// Returns the RGBA8 image data.
fn generate_image_data(&self) -> Vec<u8> {
fn generate_image_data(&mut self) -> Vec<u8> {
// Select random colors for the inner and outer ellipses.
let mut rng = ThreadRng::default();
let outer_color: [u8; 3] = array::from_fn(|_| rng.random());
let inner_color: [u8; 3] = array::from_fn(|_| rng.random());
let outer_color: [u8; 3] = array::from_fn(|_| self.rng.random());
let inner_color: [u8; 3] = array::from_fn(|_| self.rng.random());

let image_byte_size = 4usize
* MipmapSizeIterator::new(self)
Expand Down