Misc solari cleanup #22347
Merged
Misc solari cleanup #22347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
added
D-Trivial
SparkyPotato
suggested changes
Jan 2, 2026
| var rng = cell_index + constants.frame_index; | ||
| if active_cell_id.x >= world_cache_active_cells_count { return; } | ||
|
|
||
| // TODO: Initialize newly active cells with data from an adjacent LOD |
Contributor
There was a problem hiding this comment.
We should probably keep the TODO
Contributor
Author
There was a problem hiding this comment.
Nah I'm not a big fan of TODOs in code, and I'm not sure what shape it'll take if we ever add it. E.g. it might make more sense to have a dedicated step each frame to propagate finer LODs into coarser LODs, and skip the coarse LOD update entirely or something.
SparkyPotato
reviewed
Jan 2, 2026
SparkyPotato
approved these changes
Jan 3, 2026
alice-i-cecile
approved these changes
Jan 3, 2026
alice-i-cecile
added
C-Code-Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup PR to prep for a future PR (no functional changes).
Easiest to review if you hide whitespace changes in the diff.