Skip to content

Replace the section info septuple in bevy_text::pipeline with a struct #22352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ickshonpe wants to merge 3 commits into from
Closed

Replace the section info septuple in bevy_text::pipeline with a struct #22352

ickshonpe wants to merge 3 commits into from

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 2, 2026 •
edited
Loading

Objective

Using a septuple to store the section data makes the module harder to follow.

Solution

  • Replace the septuple with a struct TextSectionInfo with named fields.
  • Rename the private glyph_info field of TextPipeline to section_info_buffer. It stores per-section data, not per-glyph.

Testing

If there are any problems, the screenshot CI will pick them up.

@ickshonpe ickshonpe added C-Code-Quality A section of code that is hard to understand or change A-Text Rendering and layout for characters D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 2, 2026
@ickshonpe ickshonpe changed the title Replace the septuple in bevy_text::pipeline with a struct with named fields Replace the section info septuple in bevy_text::pipeline with a struct Jan 2, 2026
@ickshonpe
Copy link
Contributor Author

ickshonpe commented Jan 3, 2026 •
edited
Loading

Closed in favour #22156 which removes the septuple completely.

@ickshonpe ickshonpe closed this Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Firesz25 Firesz25 Firesz25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ickshonpe @Firesz25