derive Reflect on FpsOverlayConfig and FrameTimeGraphConfig #22360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
maybe we can get that into 0.18 ? |
mirsella
force-pushed
the
reflect-fpsoverlayconfig
branch
from
58f9c35 to
7779130
Compare
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jan 3, 2026
cart
pushed a commit
that referenced
this pull request
Jan 8, 2026
## Summary Derives `Reflect` on `FpsOverlayConfig` and `FrameTimeGraphConfig` to enable runtime reflection capabilities for these configuration structs. For example, allows modifying the config in bevy inspector egui. ## Changes - Added `Reflect` derive to `FpsOverlayConfig` with `#[reflect(Resource)]` attribute - Added `Reflect` derive to `FrameTimeGraphConfig` (required since it's a field in `FpsOverlayConfig`) - Added `use bevy_reflect::Reflect;` import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Derives
ReflectonFpsOverlayConfigandFrameTimeGraphConfigto enable runtime reflection capabilities for these configuration structs.For example, allows modifying the config in bevy inspector egui.
Changes
Reflectderive toFpsOverlayConfigwith#[reflect(Resource)]attributeReflectderive toFrameTimeGraphConfig(required since it's a field inFpsOverlayConfig)use bevy_reflect::Reflect;import