Skip to content

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 3, 2026

Objective

  • Name error type more accurately, its about the shader cache not pipeline cache.
  • Put naga error in Box to make type smaller and clippy happy

Solution

  • do it

Testing

  • examples run

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 3, 2026
@IQuick143 IQuick143 added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Jan 3, 2026
@kfc35 kfc35 added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jan 8, 2026
Copy link
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i understand correctly, the change to box the error doesn’t change anything with how #[error(transparent)] outputs, so this should be ok, but someone can double check me on this

@IceSentry IceSentry added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 9, 2026
@mockersf mockersf added this pull request to the merge queue Jan 13, 2026
Merged via the queue into bevyengine:main with commit e64f04f Jan 13, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants