-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix copy-pasting mistake in extended material bindless example #22373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Feel free to move it out of the milestone, I just put it there because having fixed docs would be neat. |
pcwalton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks correct, sorry for the mistake there!
|
@pcwalton thank you so much for making this example in the first place, it was exactly what I needed and I think I would not have been able to piece it together on my own if it didn't exist :D |
NicoZweifel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! I think having good docs would be really clutch for bindless, it took me days to figure out quirks with bindless.
Co-authored-by: Nico Zweifel <[email protected]>
Objective
Solution
#{MATERIAL_BIND_GROUP}in the docs, given that it's used in the shader :)Testing