Skip to content

Conversation

@janhohenheim
Copy link
Member

@janhohenheim janhohenheim commented Jan 4, 2026

Objective

  • The docs are a bit weird, which is probably due to someone at some point accidentally copy-pasting the wgsl correspondence code

Solution

  • Write the actual code
  • Also use our fancy #{MATERIAL_BIND_GROUP} in the docs, given that it's used in the shader :)
  • Split the line a liiiiittle bit differently

Testing

  • None, just docs. Well, I did make sure that the stuff in the docs is the same as in the shader!

@janhohenheim janhohenheim added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 4, 2026
@janhohenheim janhohenheim modified the milestones: 0.19, 0.18 Jan 4, 2026
@janhohenheim
Copy link
Member Author

Feel free to move it out of the milestone, I just put it there because having fixed docs would be neat.

@janhohenheim janhohenheim added the C-Examples An addition or correction to our examples label Jan 4, 2026
Copy link
Contributor

@pcwalton pcwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks correct, sorry for the mistake there!

@janhohenheim
Copy link
Member Author

@pcwalton thank you so much for making this example in the first place, it was exactly what I needed and I think I would not have been able to piece it together on my own if it didn't exist :D

Copy link
Contributor

@NicoZweifel NicoZweifel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I think having good docs would be really clutch for bindless, it took me days to figure out quirks with bindless.

@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 4, 2026
@janhohenheim janhohenheim changed the title Fix likely copy-pasting mistake in extended material bindless example Fix copy-pasting mistake in extended material bindless example Jan 4, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 5, 2026
Merged via the queue into bevyengine:main with commit 9737c30 Jan 5, 2026
40 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants