Add Ray.plane_intersection_point to simplify example code #22381
+37
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Usability
| None | ||
| } | ||
|
|
||
| /// Returns the intersection point with a plane, if it exists. |
Member
There was a problem hiding this comment.
These docs should call out that it's a combination of the other two methods.
| } | ||
|
|
||
| /// Get the distance to a plane if the ray intersects it | ||
| /// Returns the distance to a plane if the ray intersects it. |
Member
There was a problem hiding this comment.
We should mention the new method here too :)
alice-i-cecile
approved these changes
Jan 6, 2026
IQuick143
reviewed
Jan 6, 2026
IQuick143
reviewed
Jan 6, 2026
IQuick143
approved these changes
Jan 6, 2026
IQuick143
added
S-Ready-For-Final-Review
Co-authored-by: IQuick 143 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
-Added a plane_intersection_point method, making the usage of rays more intuitive.
-This method simplifies 2 out of 4 examples that previously had to manually calculate intersection points using intersect_plane + get_point.