Skip to content

Improve macro hygiene of children! by re-defining it in terms of related! #22384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Jan 5, 2026
Merged

Improve macro hygiene of children! by re-defining it in terms of related! #22384

alice-i-cecile merged 1 commit into from
Jan 5, 2026

Conversation

@ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Jan 5, 2026 •
edited
Loading

Objective

Same deal as #22331 but for the children! macro.

Solution

Make children! delegate to related! in order to:

  • Remove the need to import SpawnRelated when using it.
  • Reduce code duplication.
  • Make children! look less special-cased (it's just related! with a bevy-provided relation type).

Testing

Removed imports of SpawnRelated where it's no longer needed, to prove it works.

@ItsDoot ItsDoot added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Macros Code that generates Rust code labels Jan 5, 2026
@ItsDoot ItsDoot added this to the 0.18 milestone Jan 5, 2026
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 5, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 5, 2026
Merged via the queue into bevyengine:main with commit 11d485b Jan 5, 2026
55 checks passed
cart pushed a commit that referenced this pull request Jan 8, 2026
@ItsDoot @cart
Improve macro hygiene of children! by re-defining it in terms of `r…
b991a5a 
…elated!` (#22384)

# Objective

Same deal as #22331 but for the `children!` macro.

## Solution

Make `children!`  delegate to `related!` in order to:
- Remove the need to import `SpawnRelated` when using it.
- Reduce code duplication.
- Make `children!` look less special-cased (it's just `related!` with a
bevy-provided relation type).

## Testing

Removed imports of `SpawnRelated` where it's no longer needed, to prove
it works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@hukasu hukasu hukasu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Macros Code that generates Rust code D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

3 participants

@ItsDoot @alice-i-cecile @hukasu