Skip to content

Refactor App and SubApp internals for better separation #9202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james7132 merged 5 commits into from
Mar 31, 2024
Merged

Refactor App and SubApp internals for better separation #9202

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65fe996
update app crate
maniwani Mar 31, 2024
c8650d9
update plugin crates
maniwani Mar 31, 2024
2e4e372
update benches, examples, tests
maniwani Mar 31, 2024
27fb241
remove unused line from comment
maniwani Mar 31, 2024
825c21f
fix typo in comment
maniwani Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benches/benches/bevy_ecs/scheduling/schedule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,19 +127,19 @@ pub fn empty_schedule_run(criterion: &mut Criterion) {
let mut schedule = Schedule::default();
schedule.set_executor_kind(bevy_ecs::schedule::ExecutorKind::SingleThreaded);
group.bench_function("SingleThreaded", |bencher| {
bencher.iter(|| schedule.run(&mut app.world));
bencher.iter(|| schedule.run(app.world_mut()));
});

let mut schedule = Schedule::default();
schedule.set_executor_kind(bevy_ecs::schedule::ExecutorKind::MultiThreaded);
group.bench_function("MultiThreaded", |bencher| {
bencher.iter(|| schedule.run(&mut app.world));
bencher.iter(|| schedule.run(app.world_mut()));
});

let mut schedule = Schedule::default();
schedule.set_executor_kind(bevy_ecs::schedule::ExecutorKind::Simple);
group.bench_function("Simple", |bencher| {
bencher.iter(|| schedule.run(&mut app.world));
bencher.iter(|| schedule.run(app.world_mut()));
});
group.finish();
}
Loading